Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2740743003: Fixing a crash due to calling [RWHVCocoa attributedSubstringForProposedRange] when there is no focu… (Closed)

Created:
3 years, 9 months ago by EhsanK
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fixing a crash due to calling [RWHVCocoa attributedSubstringForProposedRange] when there is no focused <input>. RWHVCocoa::attributedSubstringForProposedRange maybe called when there is no focused <input>. In such cases, renderWidgetHostView_->GetCompositionInfo() returns nullptr. BUG=698672 Review-Url: https://codereview.chromium.org/2732143002 Cr-Commit-Position: refs/heads/master@{#455028} (cherry picked from commit 8c80b233da12ca81bece40f77b990a84a13c75a2) Review-Url: https://codereview.chromium.org/2740743003 . Cr-Commit-Position: refs/branch-heads/3029@{#65} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/e63f1c2fb0a59ee8d29ab49a946cb1c5c24e3d2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
EhsanK
3 years, 9 months ago (2017-03-08 20:23:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e63f1c2fb0a59ee8d29ab49a946cb1c5c24e3d2d.

Powered by Google App Engine
This is Rietveld 408576698