Fixing a crash due to calling [RWHVCocoa attributedSubstringForProposedRange] when there is no focu…

Fixing a crash due to calling [RWHVCocoa attributedSubstringForProposedRange] when there is no focused <input>.

RWHVCocoa::attributedSubstringForProposedRange maybe called when there is no
focused <input>. In such cases, renderWidgetHostView_->GetCompositionInfo() returns
nullptr.

BUG=698672
Review-Url: https://codereview.chromium.org/2732143002
Cr-Commit-Position: refs/heads/master@{#455028}
Committed: https://chromium.googlesource.com/chromium/src/+/8c80b233da12ca81bece40f77b990a84a13c75a2

[EhsanK, 2017-03-06 23:36:18]

ekaramad@chromium.org changed reviewers:
+ avi@chromium.org

[EhsanK, 2017-03-06 23:36:19]

Hello Avi,

Could you please take a look? Thanks!

https://codereview.chromium.org/2732143002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/2732143002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:3100: if
(compositionInfo && !compositionInfo->range.is_empty()) {
We do get here when <input> is not focused (left some comments in the associated
bug). So in those cases this will be nullptr.

[Avi (use Gerrit), 2017-03-06 23:39:10]

lgtm

https://codereview.chromium.org/2732143002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/2732143002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:3100: if
(compositionInfo && !compositionInfo->range.is_empty()) {
On 2017/03/06 23:36:19, EhsanK wrote:
> We do get here when <input> is not focused (left some comments in the
associated
> bug). So in those cases this will be nullptr.

Can you drop a note in the code explaining when this is null? For the next
person who runs by this...

[EhsanK, 2017-03-07 02:48:53]

Thanks Avi. I added a short comment. I will try to CQ and keep monitoring the
crash reports to see if this hopefully stopped it (perhaps on Wednesday since we
passed the Canary cut for today).

https://codereview.chromium.org/2732143002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/2732143002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:3100: if
(compositionInfo && !compositionInfo->range.is_empty()) {
On 2017/03/06 23:39:10, Avi wrote:
> On 2017/03/06 23:36:19, EhsanK wrote:
> > We do get here when <input> is not focused (left some comments in the
> associated
> > bug). So in those cases this will be nullptr.
> 
> Can you drop a note in the code explaining when this is null? For the next
> person who runs by this... 

Sure. I still don't know the exact repro but I will explain the potential
scenario and bug no.

[EhsanK, 2017-03-07 02:48:58]

The CQ bit was checked by ekaramad@chromium.org

[EhsanK, 2017-03-07 02:48:58]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2732143002/#ps20001
(title: "Added a comment")

[commit-bot: I haz the power, 2017-03-07 02:49:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 03:13:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488854938481540,
"parent_rev": "4d8296ca0eee12ba5876ea0cafde76e0f8359981", "commit_rev":
"8c80b233da12ca81bece40f77b990a84a13c75a2"}

[commit-bot: I haz the power, 2017-03-07 03:14:29]

Description was changed from

==========
Fixing a crash due to calling [RWHVCocoa attributedSubstringForProposedRange]
when there is no focused <input>.

RWHVCocoa::attributedSubstringForProposedRange maybe called when there is no
focused <input>. In such cases, renderWidgetHostView_->GetCompositionInfo()
returns
nullptr.

BUG=698672
==========

to

==========
Fixing a crash due to calling [RWHVCocoa attributedSubstringForProposedRange]
when there is no focused <input>.

RWHVCocoa::attributedSubstringForProposedRange maybe called when there is no
focused <input>. In such cases, renderWidgetHostView_->GetCompositionInfo()
returns
nullptr.

BUG=698672

Review-Url: https://codereview.chromium.org/2732143002
Cr-Commit-Position: refs/heads/master@{#455028}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c80b233da12ca81bece40f77b99...
==========

[commit-bot: I haz the power, 2017-03-07 03:14:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8c80b233da12ca81bece40f77b99...