Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2740743003: Fixing a crash due to calling [RWHVCocoa attributedSubstringForProposedRange] when there is no focu… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index b67a5f3d160e4521c879bcdb7bf30b7fa005876a..d60da64073eb29024c09b027513251a0ad2e25d3 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -3097,7 +3097,10 @@ extern NSString *NSTextInputReplacementRangeAttributeName;
if (!selection)
return nil;
- if (!compositionInfo->range.is_empty()) {
+ if (compositionInfo && !compositionInfo->range.is_empty()) {
+ // This method might get called after TextInputState.type is reset to none,
+ // in which case there will be no composition range information
+ // (https://crbug.com/698672).
expected_text = &markedText_;
expected_range = compositionInfo->range;
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698