extensions/renderer/api_event_handler.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_event_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_event_handler.cc

diff --git a/extensions/renderer/api_event_handler.cc b/extensions/renderer/api_event_handler.cc

index 794b19436638ab4200778061ad77bc629fbbeed5..352e6fd767284e8a9379fd280f85a42dc96ac174 100644

--- a/extensions/renderer/api_event_handler.cc

+++ b/extensions/renderer/api_event_handler.cc

@@ -157,7 +157,7 @@ void APIEventHandler::FireEventInContext(const std::string& event_name,

std::vector<v8::Local<v8::Value>> v8_args;

v8_args.reserve(args.GetSize());

for (const auto& arg : args)

- v8_args.push_back(converter->ToV8Value(arg.get(), context));

+ v8_args.push_back(converter->ToV8Value(&arg, context));

emitter->Fire(context, &v8_args);

} else {

v8::Isolate* isolate = context->GetIsolate();