Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: extensions/renderer/api_binding.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_binding.cc
diff --git a/extensions/renderer/api_binding.cc b/extensions/renderer/api_binding.cc
index e16bef1472d75bd955cad24d18260e2a29192ae8..c5c7f47d15ca55f0d2f21e0f5e1448e888fca094 100644
--- a/extensions/renderer/api_binding.cc
+++ b/extensions/renderer/api_binding.cc
@@ -149,7 +149,7 @@ APIBinding::APIBinding(const std::string& api_name,
if (function_definitions) {
for (const auto& func : *function_definitions) {
const base::DictionaryValue* func_dict = nullptr;
- CHECK(func->GetAsDictionary(&func_dict));
+ CHECK(func.GetAsDictionary(&func_dict));
std::string name;
CHECK(func_dict->GetString("name", &name));
@@ -166,7 +166,7 @@ APIBinding::APIBinding(const std::string& api_name,
if (type_definitions) {
for (const auto& type : *type_definitions) {
const base::DictionaryValue* type_dict = nullptr;
- CHECK(type->GetAsDictionary(&type_dict));
+ CHECK(type.GetAsDictionary(&type_dict));
std::string id;
CHECK(type_dict->GetString("id", &id));
auto argument_spec = base::MakeUnique<ArgumentSpec>(*type_dict);
@@ -191,7 +191,7 @@ APIBinding::APIBinding(const std::string& api_name,
if (type_dict->GetList("functions", &type_functions)) {
for (const auto& func : *type_functions) {
const base::DictionaryValue* func_dict = nullptr;
- CHECK(func->GetAsDictionary(&func_dict));
+ CHECK(func.GetAsDictionary(&func_dict));
std::string function_name;
CHECK(func_dict->GetString("name", &function_name));
@@ -209,7 +209,7 @@ APIBinding::APIBinding(const std::string& api_name,
events_.reserve(event_definitions->GetSize());
for (const auto& event : *event_definitions) {
const base::DictionaryValue* event_dict = nullptr;
- CHECK(event->GetAsDictionary(&event_dict));
+ CHECK(event.GetAsDictionary(&event_dict));
std::string name;
CHECK(event_dict->GetString("name", &name));
std::string full_name =

Powered by Google App Engine
This is Rietveld 408576698