extensions/renderer/api_request_handler.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_request_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_request_handler.cc

diff --git a/extensions/renderer/api_request_handler.cc b/extensions/renderer/api_request_handler.cc

index 1dd7ca21df1c8e92395443bfecbdc21e3614a6a6..0020936626fad1dbf57b1f64cbb283d1ac42beb6 100644

--- a/extensions/renderer/api_request_handler.cc

+++ b/extensions/renderer/api_request_handler.cc

@@ -121,7 +121,7 @@ void APIRequestHandler::CompleteRequest(int request_id,

for (const auto& arg : pending_request.callback_arguments)

args.push_back(arg.Get(isolate));

for (const auto& arg : response_args)

- args.push_back(converter->ToV8Value(arg.get(), context));

+ args.push_back(converter->ToV8Value(&arg, context));

blink::WebScopedUserGesture user_gesture(pending_request.user_gesture_token);

if (!error.empty())