Change base::Value::ListStorage to std::vector<base::Value>

extensions/common/extension_l10n_util_unittest.cc

Index: extensions/common/extension_l10n_util_unittest.cc
diff --git a/extensions/common/extension_l10n_util_unittest.cc b/extensions/common/extension_l10n_util_unittest.cc
index 3caba365958e17b44483c173ecbbe6a4e21157b1..f83dc892fdbfb51a419e6fa1c5fd63441b33fd20 100644
--- a/extensions/common/extension_l10n_util_unittest.cc
+++ b/extensions/common/extension_l10n_util_unittest.cc
@@ -430,6 +430,8 @@ TEST(ExtensionL10nUtil, LocalizeManifestWithNameDescriptionFileHandlerTitle) {
   manifest.Set(keys::kFileBrowserHandlers, handlers);
   base::DictionaryValue* handler = new base::DictionaryValue();
   handlers->Append(base::WrapUnique(handler));
+  // |handler| is invalidated at this point, so it needs to be reset.
+  handlers->GetDictionary(handlers->GetSize() - 1, &handler);

[Devlin, 2017/03/15 15:25:04]

We can just inline the creation of the new DictionaryValue, since we won't use
it before refetching.
handlers->Append(base::MakeUnique<base::DictionaryValue>());
base::DictionaryValue* handler = nullptr;
handlers->GetDictionary(...);

[jdoerrie, 2017/03/24 08:54:37]

Done.

   handler->SetString(keys::kPageActionDefaultTitle,
                      "__MSG_file_handler_title__");