Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: extensions/common/manifest_handlers/requirements_info.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handlers/requirements_info.cc
diff --git a/extensions/common/manifest_handlers/requirements_info.cc b/extensions/common/manifest_handlers/requirements_info.cc
index d73af89c0902de0c689f704675ed6525e5980fdc..0acbf7baddc187506faa674d0c5fd7cd082de9cc 100644
--- a/extensions/common/manifest_handlers/requirements_info.cc
+++ b/extensions/common/manifest_handlers/requirements_info.cc
@@ -117,7 +117,7 @@ bool RequirementsHandler::Parse(Extension* extension, base::string16* error) {
for (base::ListValue::const_iterator feature_iter = features->begin();
feature_iter != features->end(); ++feature_iter) {
std::string feature;
- if ((*feature_iter)->GetAsString(&feature)) {
+ if (feature_iter->GetAsString(&feature)) {
if (feature == "webgl") {
requirements->webgl = true;
} else if (feature == "css3d") {

Powered by Google App Engine
This is Rietveld 408576698