extensions/browser/api/networking_private/networking_private_api.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_api.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/sync/driver/about_sync_util.cc ('K') | « extensions/browser/api/device_permissions_manager.cc ('k') | extensions/browser/api/networking_private/networking_private_chromeos.cc » ('j') | extensions/common/extension_l10n_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_api.cc

diff --git a/extensions/browser/api/networking_private/networking_private_api.cc b/extensions/browser/api/networking_private/networking_private_api.cc

index bbda2bbf81ab1e5405886ec25b93ef76f60f15de..83023995140a7cc1fa5dff8751cc0202bef9db96 100644

--- a/extensions/browser/api/networking_private/networking_private_api.cc

+++ b/extensions/browser/api/networking_private/networking_private_api.cc

@@ -370,7 +370,7 @@ NetworkingPrivateGetEnabledNetworkTypesFunction::Run() {

for (base::ListValue::iterator iter = enabled_networks_onc_types->begin();

iter != enabled_networks_onc_types->end(); ++iter) {

std::string type;

- if (!(*iter)->GetAsString(&type))

+ if (!iter->GetAsString(&type))

NOTREACHED();

if (type == ::onc::network_type::kEthernet) {

enabled_networks_list->AppendString(