extensions/browser/api/networking_private/networking_private_chromeos.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_chromeos.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/sync/driver/about_sync_util.cc ('K') | « extensions/browser/api/networking_private/networking_private_api.cc ('k') | extensions/browser/api/networking_private/networking_private_linux.cc » ('j') | extensions/common/extension_l10n_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_chromeos.cc

diff --git a/extensions/browser/api/networking_private/networking_private_chromeos.cc b/extensions/browser/api/networking_private/networking_private_chromeos.cc

index 0396e473ceaac133fded3a281cb5dc1f3baa5dfd..bd7cdd1bab9c013b058494d4d4d165e7a777dba7 100644

--- a/extensions/browser/api/networking_private/networking_private_chromeos.cc

+++ b/extensions/browser/api/networking_private/networking_private_chromeos.cc

@@ -447,9 +447,9 @@ void NetworkingPrivateChromeOS::GetNetworks(

chromeos::network_util::TranslateNetworkListToONC(

pattern, configured_only, visible_only, limit);

- for (const auto& value : *network_properties_list) {

+ for (auto& value : *network_properties_list) {

base::DictionaryValue* network_dict = nullptr;

- value->GetAsDictionary(&network_dict);

+ value.GetAsDictionary(&network_dict);

DCHECK(network_dict);

if (GetThirdPartyVPNDictionary(network_dict))

AppendThirdPartyProviderName(network_dict);