extensions/browser/api/device_permissions_manager.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/device_permissions_manager.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/device_permissions_manager.cc

diff --git a/extensions/browser/api/device_permissions_manager.cc b/extensions/browser/api/device_permissions_manager.cc

index f8eebb186e56def0b609aecbb84d9984fb907078..b81ad207e559b9fd908bf139c9e6219481a0ed89 100644

--- a/extensions/browser/api/device_permissions_manager.cc

+++ b/extensions/browser/api/device_permissions_manager.cc

@@ -254,7 +254,7 @@ std::set<scoped_refptr<DevicePermissionEntry>> GetDevicePermissionEntries(

for (const auto& entry : *devices) {

const base::DictionaryValue* entry_dict;

- if (entry->GetAsDictionary(&entry_dict)) {

+ if (entry.GetAsDictionary(&entry_dict)) {

scoped_refptr<DevicePermissionEntry> device_entry =

ReadDevicePermissionEntry(entry_dict);

if (entry_dict) {