Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2740123004: MIPS[64]: Support for MSA instructions (Closed)

Created:
3 years, 9 months ago by dusan.simicic
Modified:
3 years, 9 months ago
Reviewers:
ivica.bogosavljevic, v8-mips-ports, miran.karic, Benedikt Meurer, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Support for MSA instructions This patch adds support for MIPS SIMD (MSA) instructions in Assembler and Decoder (disassembler) classes. MSA instructions are implemented for both mips32 and mips64 architectures. BUG= Review-Url: https://codereview.chromium.org/2740123004 Cr-Commit-Position: refs/heads/master@{#44148} Committed: https://chromium.googlesource.com/v8/v8/+/cd5c0095696f71ed60da2bc41a2da2e5d302a580

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7012 lines, -15 lines) Patch
M src/base/cpu.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/base/cpu.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/assembler-mips.h View 8 chunks +734 lines, -6 lines 0 comments Download
M src/mips/assembler-mips.cc View 3 chunks +621 lines, -0 lines 0 comments Download
M src/mips/constants-mips.h View 14 chunks +485 lines, -1 line 0 comments Download
M src/mips/constants-mips.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/mips/disasm-mips.cc View 17 chunks +923 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64.h View 8 chunks +738 lines, -6 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 3 chunks +630 lines, -0 lines 2 comments Download
M src/mips64/constants-mips64.h View 13 chunks +484 lines, -0 lines 0 comments Download
M src/mips64/constants-mips64.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 17 chunks +925 lines, -1 line 0 comments Download
M test/cctest/test-disasm-mips.cc View 2 chunks +692 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 2 chunks +696 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
dusan.simicic
PTAL
3 years, 9 months ago (2017-03-10 09:12:56 UTC) #2
ivica.bogosavljevic
lgtm I would like to see tests for the newly introduced instructions, but not in ...
3 years, 9 months ago (2017-03-21 13:50:11 UTC) #3
dusan.simicic
On 2017/03/21 13:50:11, ivica.bogosavljevic wrote: > lgtm > > I would like to see tests ...
3 years, 9 months ago (2017-03-21 15:02:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740123004/1
3 years, 9 months ago (2017-03-27 12:18:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37710)
3 years, 9 months ago (2017-03-27 12:21:24 UTC) #12
dusan.simicic
+bmeurer, +jkummerow for cpu.cc and globals.h files
3 years, 9 months ago (2017-03-27 12:53:35 UTC) #14
Jakob Kummerow
lgtm
3 years, 9 months ago (2017-03-27 12:56:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740123004/1
3 years, 9 months ago (2017-03-27 13:17:46 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 13:20:43 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cd5c0095696f71ed60da2bc41a2da2e5d30...

Powered by Google App Engine
This is Rietveld 408576698