Last sets of tests that can move to common_unittests

Last sets of tests that can move to common_unittests

This way they run in both mash_unittests and ash_unittests.
Interesting things of note:
. Had to remove DCHECKs for GetRootWindowForDisplayId() as some tests
  call with invalid.
. Had to rename class in mus named WindowManagerTest as it conflicts
  with test with same name in ash.

BUG=622486, 631103, 637853, 648733, 695556, 696028, 698091, 698129, 698878, 698887, 698888, 698892, 698894, 698895, 698914, 699172, 699175, 693114
TEST=test changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2739703003
Cr-Commit-Position: refs/heads/master@{#455272}
Committed: https://chromium.googlesource.com/chromium/src/+/ea37af717f1569dd93282e09b6fb49ff22b771f8

[sky, 2017-03-07 20:56:10]

https://codereview.chromium.org/2739703003/diff/1/ash/wm/window_modality_cont...
File ash/wm/window_modality_controller_unittest.cc (left):

https://codereview.chromium.org/2739703003/diff/1/ash/wm/window_modality_cont...
ash/wm/window_modality_controller_unittest.cc:476:
EXPECT_NE(static_cast<aura::Window*>(NULL), child);
I changed this single line as this test was failing and in analyzing the code I
figured I would update this line.

[sky, 2017-03-07 20:56:13]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 20:56:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-03-07 21:36:01]

lgtm with nits

https://codereview.chromium.org/2739703003/diff/1/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2739703003/diff/1/ash/BUILD.gn#newcode1411
ash/BUILD.gn:1411: # TODO: fails because keyboard is not enabled in mash.
optional nit: "the virtual keyboard"

https://codereview.chromium.org/2739703003/diff/1/ash/mus/window_manager_unit...
File ash/mus/window_manager_unittest.cc (right):

https://codereview.chromium.org/2739703003/diff/1/ash/mus/window_manager_unit...
ash/mus/window_manager_unittest.cc:65: class MusWindowManagerTest : public
service_manager::test::ServiceTest {
optional nit: rename file mus_window_manager_unittest.cc

https://codereview.chromium.org/2739703003/diff/1/ash/test/ash_test_base.cc
File ash/test/ash_test_base.cc (right):

https://codereview.chromium.org/2739703003/diff/1/ash/test/ash_test_base.cc#n...
ash/test/ash_test_base.cc:361: // The functionality done here doesn't make sense
in mash.
nit: elaborate on this comment, cite a bug?

https://codereview.chromium.org/2739703003/diff/1/ash/wm/overview/window_sele...
File ash/wm/overview/window_selector_unittest.cc (right):

https://codereview.chromium.org/2739703003/diff/1/ash/wm/overview/window_sele...
ash/wm/overview/window_selector_unittest.cc:867: // TODO: fails because of
metrics. http://crbug.com/698129.
nit: re-target/title bug?

https://codereview.chromium.org/2739703003/diff/1/ash/wm/system_modal_contain...
File ash/wm/system_modal_container_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2739703003/diff/1/ash/wm/system_modal_contain...
ash/wm/system_modal_container_layout_manager_unittest.cc:155: // TODO: mash
doesn't support keyboard. http://crbug.com/698892.
nit: virtual keyboard here and below?

https://codereview.chromium.org/2739703003/diff/1/ash/wm/window_modality_cont...
File ash/wm/window_modality_controller_unittest.cc (left):

https://codereview.chromium.org/2739703003/diff/1/ash/wm/window_modality_cont...
ash/wm/window_modality_controller_unittest.cc:476:
EXPECT_NE(static_cast<aura::Window*>(NULL), child);
On 2017/03/07 20:56:10, sky wrote:
> I changed this single line as this test was failing and in analyzing the code
I
> figured I would update this line.

Acknowledged.

[sky, 2017-03-07 21:43:30]

https://codereview.chromium.org/2739703003/diff/1/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2739703003/diff/1/ash/BUILD.gn#newcode1411
ash/BUILD.gn:1411: # TODO: fails because keyboard is not enabled in mash.
On 2017/03/07 21:36:01, msw wrote:
> optional nit: "the virtual keyboard"

Done.

https://codereview.chromium.org/2739703003/diff/1/ash/mus/window_manager_unit...
File ash/mus/window_manager_unittest.cc (right):

https://codereview.chromium.org/2739703003/diff/1/ash/mus/window_manager_unit...
ash/mus/window_manager_unittest.cc:65: class MusWindowManagerTest : public
service_manager::test::ServiceTest {
On 2017/03/07 21:36:01, msw wrote:
> optional nit: rename file mus_window_manager_unittest.cc

I would rather keep the file name matching the name of the class under test
(WindowManager). I added a comment about why the name is inconsistent.

https://codereview.chromium.org/2739703003/diff/1/ash/test/ash_test_base.cc
File ash/test/ash_test_base.cc (right):

https://codereview.chromium.org/2739703003/diff/1/ash/test/ash_test_base.cc#n...
ash/test/ash_test_base.cc:361: // The functionality done here doesn't make sense
in mash.
On 2017/03/07 21:36:01, msw wrote:
> nit: elaborate on this comment, cite a bug?

There is no bug, but I expanded the comment.

https://codereview.chromium.org/2739703003/diff/1/ash/wm/overview/window_sele...
File ash/wm/overview/window_selector_unittest.cc (right):

https://codereview.chromium.org/2739703003/diff/1/ash/wm/overview/window_sele...
ash/wm/overview/window_selector_unittest.cc:867: // TODO: fails because of
metrics. http://crbug.com/698129.
On 2017/03/07 21:36:01, msw wrote:
> nit: re-target/title bug?

Done.

https://codereview.chromium.org/2739703003/diff/1/ash/wm/system_modal_contain...
File ash/wm/system_modal_container_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2739703003/diff/1/ash/wm/system_modal_contain...
ash/wm/system_modal_container_layout_manager_unittest.cc:155: // TODO: mash
doesn't support keyboard. http://crbug.com/698892.
On 2017/03/07 21:36:01, msw wrote:
> nit: virtual keyboard here and below?

Done.

[sky, 2017-03-07 21:43:38]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-07 21:43:39]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2739703003/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-03-07 21:44:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:59:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488923018843520,
"parent_rev": "61ecccaf435be8286921c0dc64e37edd7c88e799", "commit_rev":
"ea37af717f1569dd93282e09b6fb49ff22b771f8"}

[commit-bot: I haz the power, 2017-03-07 23:00:26]

Description was changed from

==========
Last sets of tests that can move to common_unittests

This way they run in both mash_unittests and ash_unittests.
Interesting things of note:
. Had to remove DCHECKs for GetRootWindowForDisplayId() as some tests
  call with invalid.
. Had to rename class in mus named WindowManagerTest as it conflicts
  with test with same name in ash.

BUG=622486,631103,637853,648733,695556,696028,698091,698129,698878,698887,698888,698892,698894,698895,698914,699172,699175,693114
TEST=test changes
R=msw@chromium.org
==========

to

==========
Last sets of tests that can move to common_unittests

This way they run in both mash_unittests and ash_unittests.
Interesting things of note:
. Had to remove DCHECKs for GetRootWindowForDisplayId() as some tests
  call with invalid.
. Had to rename class in mus named WindowManagerTest as it conflicts
  with test with same name in ash.

BUG=622486,631103,637853,648733,695556,696028,698091,698129,698878,698887,698888,698892,698894,698895,698914,699172,699175,693114
TEST=test changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2739703003
Cr-Commit-Position: refs/heads/master@{#455272}
Committed:
https://chromium.googlesource.com/chromium/src/+/ea37af717f1569dd93282e09b6fb...
==========

[commit-bot: I haz the power, 2017-03-07 23:00:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea37af717f1569dd93282e09b6fb...