Last sets of tests that can move to common_unittests

ash/wm/system_modal_container_layout_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/system_modal_container_layout_manager.h"
 
 #include <memory>
 
 #include "ash/common/session/session_state_delegate.h"
 #include "ash/common/wm/container_finder.h"
@@ skipping 134 matching lines @@
 
 }  // namespace
 
 class SystemModalContainerLayoutManagerTest : public AshTestBase {
  public:
   void SetUp() override {
     // Allow a virtual keyboard (and initialize it per default).
     base::CommandLine::ForCurrentProcess()->AppendSwitch(
         keyboard::switches::kEnableVirtualKeyboard);
     AshTestBase::SetUp();
-    Shell::GetPrimaryRootWindowController()->ActivateKeyboard(
-        keyboard::KeyboardController::GetInstance());
+    // TODO: mash doesn't support keyboard. http://crbug.com/698892.

[msw, 2017/03/07 21:36:01]

nit: virtual keyboard here and below?

[sky, 2017/03/07 21:43:30]

Done.

+    if (!WmShell::Get()->IsRunningInMash()) {
+      Shell::GetPrimaryRootWindowController()->ActivateKeyboard(
+          keyboard::KeyboardController::GetInstance());
+    }
   }
 
   void TearDown() override {
-    Shell::GetPrimaryRootWindowController()->DeactivateKeyboard(
-        keyboard::KeyboardController::GetInstance());
+    // TODO: mash doesn't support keyboard. http://crbug.com/698892.
+    if (!WmShell::Get()->IsRunningInMash()) {
+      Shell::GetPrimaryRootWindowController()->DeactivateKeyboard(
+          keyboard::KeyboardController::GetInstance());
+    }
     AshTestBase::TearDown();
   }
 
   aura::Window* OpenToplevelTestWindow(bool modal) {
     views::Widget* widget = views::Widget::CreateWindowWithContext(
         new TestWindow(modal), CurrentContext());
     widget->Show();
     return widget->GetNativeView();
   }
 
@@ skipping 462 matching lines @@
   modal1->Hide();
   TestWindow::CloseTestWindow(modal1.release());
   EXPECT_FALSE(AllRootWindowsHaveModalBackgrounds());
   EXPECT_TRUE(wm::IsActiveWindow(normal.get()));
 }
 
 // Test that with the visible keyboard, an existing system modal dialog gets
 // positioned into the visible area.
 TEST_F(SystemModalContainerLayoutManagerTest,
        SystemModalDialogGetPushedFromKeyboard) {
+  // TODO: mash doesn't support keyboard. http://crbug.com/698892.
+  if (WmShell::Get()->IsRunningInMash())
+    return;
+
   const gfx::Rect& container_bounds = GetModalContainer()->bounds();
   // Place the window at the bottom of the screen.
   gfx::Size modal_size(100, 100);
   gfx::Point modal_origin = gfx::Point(
       (container_bounds.right() - modal_size.width()) / 2,  // X centered
       container_bounds.bottom() - modal_size.height());     // at bottom
   gfx::Rect modal_bounds = gfx::Rect(modal_origin, modal_size);
 
   // Create a modal window.
   std::unique_ptr<aura::Window> parent(OpenToplevelTestWindow(false));
@@ skipping 16 matching lines @@
   ShowKeyboard(false);
   EXPECT_NE(modal_bounds.ToString(), modal_window->bounds().ToString());
   EXPECT_EQ(modal_size.ToString(), modal_window->bounds().size().ToString());
   EXPECT_EQ(modal_origin.x(), modal_window->bounds().x());
 }
 
 // Test that windows will not get cropped through the visible virtual keyboard -
 // if centered.
 TEST_F(SystemModalContainerLayoutManagerTest,
        SystemModalDialogGetPushedButNotCroppedFromKeyboard) {
+  // TODO: mash doesn't support keyboard. http://crbug.com/698892.
+  if (WmShell::Get()->IsRunningInMash())
+    return;
+
   const gfx::Rect& container_bounds = GetModalContainer()->bounds();
   const gfx::Size screen_size = Shell::GetPrimaryRootWindow()->bounds().size();
   // Place the window at the bottom of the screen.
   gfx::Size modal_size(100, screen_size.height() - 70);
   gfx::Point modal_origin = gfx::Point(
       (container_bounds.right() - modal_size.width()) / 2,  // X centered
       container_bounds.bottom() - modal_size.height());     // at bottom
   gfx::Rect modal_bounds = gfx::Rect(modal_origin, modal_size);
 
   // Create a modal window.
@@ skipping 13 matching lines @@
   EXPECT_EQ(modal_origin.x(), modal_window->bounds().x());
   EXPECT_EQ(0, modal_window->bounds().y());
 
   ShowKeyboard(false);
 }
 
 // Test that windows will not get cropped through the visible virtual keyboard -
 // if not centered.
 TEST_F(SystemModalContainerLayoutManagerTest,
        SystemModalDialogGetPushedButNotCroppedFromKeyboardIfNotCentered) {
+  // TODO: mash doesn't support keyboard. http://crbug.com/698892.
+  if (WmShell::Get()->IsRunningInMash())
+    return;
+
   const gfx::Size screen_size = Shell::GetPrimaryRootWindow()->bounds().size();
   // Place the window at the bottom of the screen.
   gfx::Size modal_size(100, screen_size.height() - 70);
   gfx::Point modal_origin = gfx::Point(10, 20);
   gfx::Rect modal_bounds = gfx::Rect(modal_origin, modal_size);
 
   // Create a modal window.
   std::unique_ptr<aura::Window> parent(OpenToplevelTestWindow(false));
   std::unique_ptr<aura::Window> modal_window(
       OpenTestWindowWithParent(parent.get(), true));
@@ skipping 167 matching lines @@
 
 // Make sure that events are properly blocked in multi displays environment.
 TEST_F(SystemModalContainerLayoutManagerTest, BlockEventsInMultiDisplays) {
   UpdateDisplay("500x500, 500x500");
   InputTestDelegate delegate;
   delegate.RunTest(this);
 }
 
 }  // namespace test
 }  // namespace ash