Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2454)

Unified Diff: ash/wm/system_modal_container_layout_manager_unittest.cc

Issue 2739703003: Last sets of tests that can move to common_unittests (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/panels/panel_window_resizer_unittest.cc ('k') | ash/wm/window_cycle_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/system_modal_container_layout_manager_unittest.cc
diff --git a/ash/wm/system_modal_container_layout_manager_unittest.cc b/ash/wm/system_modal_container_layout_manager_unittest.cc
index ede38a7593b23f6b21c073fca8ca9ee87d49a697..fc1c3aeb155fd3662d46c87dfcf75da35e033b77 100644
--- a/ash/wm/system_modal_container_layout_manager_unittest.cc
+++ b/ash/wm/system_modal_container_layout_manager_unittest.cc
@@ -152,13 +152,19 @@ class SystemModalContainerLayoutManagerTest : public AshTestBase {
base::CommandLine::ForCurrentProcess()->AppendSwitch(
keyboard::switches::kEnableVirtualKeyboard);
AshTestBase::SetUp();
- Shell::GetPrimaryRootWindowController()->ActivateKeyboard(
- keyboard::KeyboardController::GetInstance());
+ // TODO: mash doesn't support virtual keyboard. http://crbug.com/698892.
+ if (!WmShell::Get()->IsRunningInMash()) {
+ Shell::GetPrimaryRootWindowController()->ActivateKeyboard(
+ keyboard::KeyboardController::GetInstance());
+ }
}
void TearDown() override {
- Shell::GetPrimaryRootWindowController()->DeactivateKeyboard(
- keyboard::KeyboardController::GetInstance());
+ // TODO: mash doesn't support virtual keyboard. http://crbug.com/698892.
+ if (!WmShell::Get()->IsRunningInMash()) {
+ Shell::GetPrimaryRootWindowController()->DeactivateKeyboard(
+ keyboard::KeyboardController::GetInstance());
+ }
AshTestBase::TearDown();
}
@@ -641,6 +647,10 @@ TEST_F(SystemModalContainerLayoutManagerTest, MultiDisplays) {
// positioned into the visible area.
TEST_F(SystemModalContainerLayoutManagerTest,
SystemModalDialogGetPushedFromKeyboard) {
+ // TODO: mash doesn't support virtual keyboard. http://crbug.com/698892.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
const gfx::Rect& container_bounds = GetModalContainer()->bounds();
// Place the window at the bottom of the screen.
gfx::Size modal_size(100, 100);
@@ -677,6 +687,10 @@ TEST_F(SystemModalContainerLayoutManagerTest,
// if centered.
TEST_F(SystemModalContainerLayoutManagerTest,
SystemModalDialogGetPushedButNotCroppedFromKeyboard) {
+ // TODO: mash doesn't support virtual keyboard. http://crbug.com/698892.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
const gfx::Rect& container_bounds = GetModalContainer()->bounds();
const gfx::Size screen_size = Shell::GetPrimaryRootWindow()->bounds().size();
// Place the window at the bottom of the screen.
@@ -710,6 +724,10 @@ TEST_F(SystemModalContainerLayoutManagerTest,
// if not centered.
TEST_F(SystemModalContainerLayoutManagerTest,
SystemModalDialogGetPushedButNotCroppedFromKeyboardIfNotCentered) {
+ // TODO: mash doesn't support virtual keyboard. http://crbug.com/698892.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
const gfx::Size screen_size = Shell::GetPrimaryRootWindow()->bounds().size();
// Place the window at the bottom of the screen.
gfx::Size modal_size(100, screen_size.height() - 70);
« no previous file with comments | « ash/wm/panels/panel_window_resizer_unittest.cc ('k') | ash/wm/window_cycle_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698