Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2738983005: Revert of Update DevTools animation timeline to handle TransitionKeyframeEffectModels (Closed)

Created:
3 years, 9 months ago by kinuko
Modified:
3 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rjwright, samli, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update DevTools animation timeline to handle TransitionKeyframeEffectModels (patchset #3 id:40001 of https://codereview.chromium.org/2732223002/ ) Reason for revert: Looks like the test still keeps failing on Mac10.11. Could look into this? https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7814 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7815 Original issue's description: > Update DevTools animation timeline to handle TransitionKeyframeEffectModels > > CSS Transitions was refactored to use TransitionKeyframes instead of > AnimatableValueKeyframes in https://codereview.chromium.org/2680923005. > This patch updates the DevTools animation timeline to handle the new > data type for transitions. > > BUG=698669 > > Review-Url: https://codereview.chromium.org/2732223002 > Cr-Original-Commit-Position: refs/heads/master@{#455333} > Committed: https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199f7679edc5197 > Review-Url: https://codereview.chromium.org/2732223002 > Cr-Commit-Position: refs/heads/master@{#455995} > Committed: https://chromium.googlesource.com/chromium/src/+/d20b39ee5745592e03e549d4576783ae03f5d3a9 TBR=dgozman@chromium.org,samli@chromium.org,alancutter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=698669 Review-Url: https://codereview.chromium.org/2738983005 Cr-Commit-Position: refs/heads/master@{#456019} Committed: https://chromium.googlesource.com/chromium/src/+/a1a19dd21fddaac8e934bd06f0067b8241ea7afc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -59 lines) Patch
D third_party/WebKit/LayoutTests/inspector/animation/animation-transition-setTiming-crash.html View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/animation/animation-transition-setTiming-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kinuko
Created Revert of Update DevTools animation timeline to handle TransitionKeyframeEffectModels
3 years, 9 months ago (2017-03-10 07:52:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738983005/1
3 years, 9 months ago (2017-03-10 07:52:12 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 07:53:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1a19dd21fddaac8e934bd06f006...

Powered by Google App Engine
This is Rietveld 408576698