Connections now take a ConnectionParams instead of a pipe handle.

Changing connections to take a ConnectionParams instead of a pipe handle.
ConnectionParams will be augmented in a follow up patch to take extra
objects on Android (channels to support sending Parcelable instances).

BUG=699311
TBR=jam@chromium.org,sky@chromium.org,lhchavez@chromium.org,bradnelson@chromium.org

Review-Url: https://codereview.chromium.org/2738853002
Cr-Commit-Position: refs/heads/master@{#455921}
Committed: https://chromium.googlesource.com/chromium/src/+/aba5a6139d8823893880402cf40e9f319f2f0a97

[Jay Civelli, 2017-03-08 19:38:58]

Patchset #1 (id:1) has been deleted

[Jay Civelli, 2017-03-08 19:39:06]

Patchset #1 (id:20001) has been deleted

[Jay Civelli, 2017-03-08 19:39:13]

Patchset #1 (id:40001) has been deleted

[Jay Civelli, 2017-03-08 19:39:23]

Patchset #1 (id:60001) has been deleted

[Jay Civelli, 2017-03-08 19:39:33]

Patchset #1 (id:80001) has been deleted

[Jay Civelli, 2017-03-08 19:50:56]

Description was changed from

==========
Connections now take a ConnectionParam instead of a pipe handle.

BUG=
==========

to

==========
Changing connections to take a ConnectionParam instead of a pipe handle.
ConnectionParam will be augmented in a follow up patch to take extra
objects on Android (channels to send Parcelable instances).

BUG=699311
==========

[Jay Civelli, 2017-03-08 19:50:57]

jcivelli@chromium.org changed reviewers:
+ rockot@chromium.org

[Jay Civelli, 2017-03-08 19:51:06]

Patchset #1 (id:100001) has been deleted

[Jay Civelli, 2017-03-08 19:51:13]

Patchset #1 (id:120001) has been deleted

[Jay Civelli, 2017-03-08 19:52:24]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[Jay Civelli, 2017-03-08 19:52:57]

Description was changed from

==========
Changing connections to take a ConnectionParam instead of a pipe handle.
ConnectionParam will be augmented in a follow up patch to take extra
objects on Android (channels to send Parcelable instances).

BUG=699311
==========

to

==========
Changing connections to take a ConnectionParam instead of a pipe handle.
ConnectionParam will be augmented in a follow up patch to take extra
objects on Android (channels to support sending Parcelable instances).

BUG=699311
==========

[commit-bot: I haz the power, 2017-03-08 19:53:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 19:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 19:58:01]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jay Civelli, 2017-03-08 21:20:45]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 21:21:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 21:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 21:29:00]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jay Civelli, 2017-03-08 23:01:33]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 23:03:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 23:17:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 23:17:32]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Jay Civelli, 2017-03-09 01:01:56]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 01:03:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 01:17:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 01:17:08]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ken Rockot(use gerrit already), 2017-03-09 18:00:43]

lgtm

https://codereview.chromium.org/2738853002/diff/220001/mojo/edk/embedder/conn...
File mojo/edk/embedder/connection_param.h (right):

https://codereview.chromium.org/2738853002/diff/220001/mojo/edk/embedder/conn...
mojo/edk/embedder/connection_param.h:16: class MOJO_SYSTEM_IMPL_EXPORT
ConnectionParam {
nit: (sorry) - I think ConnectionParams (plural) would be a better name

https://codereview.chromium.org/2738853002/diff/220001/mojo/edk/system/channe...
File mojo/edk/system/channel_win.cc (right):

https://codereview.chromium.org/2738853002/diff/220001/mojo/edk/system/channe...
mojo/edk/system/channel_win.cc:354: ScopedPlatformHandle platform_handle,
Gotta remove this line

[Jay Civelli, 2017-03-09 19:06:24]

Description was changed from

==========
Changing connections to take a ConnectionParam instead of a pipe handle.
ConnectionParam will be augmented in a follow up patch to take extra
objects on Android (channels to support sending Parcelable instances).

BUG=699311
==========

to

==========
Changing connections to take a ConnectionParam instead of a pipe handle.
ConnectionParam will be augmented in a follow up patch to take extra
objects on Android (channels to support sending Parcelable instances).

BUG=699311
TBR=jam@chromium.org,sky@chromium.org,lhchavez@chromium.org
==========

[Jay Civelli, 2017-03-09 19:06:24]

jcivelli@chromium.org changed reviewers:
+ jam@chromium.org, lhchavez@chromium.org, sky@chromium.org

[Jay Civelli, 2017-03-09 19:09:53]

TBRing for trivial call site changes:
jam@ for content/
lhchavez@ for components/arc
sky@ for chrome/

https://codereview.chromium.org/2738853002/diff/220001/mojo/edk/system/channe...
File mojo/edk/system/channel_win.cc (right):

https://codereview.chromium.org/2738853002/diff/220001/mojo/edk/system/channe...
mojo/edk/system/channel_win.cc:354: ScopedPlatformHandle platform_handle,
On 2017/03/09 18:00:43, Ken Rockot wrote:
> Gotta remove this line

Done.

[Jay Civelli, 2017-03-09 19:10:03]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-09 19:10:04]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2738853002/#ps240001
(title: "Renamed to ConnectionParams")

[commit-bot: I haz the power, 2017-03-09 19:10:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2017-03-09 19:10:54]

lgtm

[commit-bot: I haz the power, 2017-03-09 19:28:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 19:28:37]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Jay Civelli, 2017-03-09 20:05:08]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-09 20:05:08]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2738853002/#ps260001
(title: "Fix Windows build")

[commit-bot: I haz the power, 2017-03-09 20:05:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jay Civelli, 2017-03-09 20:12:04]

Description was changed from

==========
Changing connections to take a ConnectionParam instead of a pipe handle.
ConnectionParam will be augmented in a follow up patch to take extra
objects on Android (channels to support sending Parcelable instances).

BUG=699311
TBR=jam@chromium.org,sky@chromium.org,lhchavez@chromium.org
==========

to

==========
Changing connections to take a ConnectionParams instead of a pipe handle.
ConnectionParams will be augmented in a follow up patch to take extra
objects on Android (channels to support sending Parcelable instances).

BUG=699311
TBR=jam@chromium.org,sky@chromium.org,lhchavez@chromium.org
==========

[jam, 2017-03-09 20:28:50]

lgtm

[commit-bot: I haz the power, 2017-03-09 20:30:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 20:30:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sky, 2017-03-09 21:09:44]

LGTM

[Jay Civelli, 2017-03-09 22:53:31]

Description was changed from

==========
Changing connections to take a ConnectionParams instead of a pipe handle.
ConnectionParams will be augmented in a follow up patch to take extra
objects on Android (channels to support sending Parcelable instances).

BUG=699311
TBR=jam@chromium.org,sky@chromium.org,lhchavez@chromium.org
==========

to

==========
Changing connections to take a ConnectionParams instead of a pipe handle.
ConnectionParams will be augmented in a follow up patch to take extra
objects on Android (channels to support sending Parcelable instances).

BUG=699311
TBR=jam@chromium.org,sky@chromium.org,lhchavez@chromium.org,bradnelson@chromi...
==========

[Jay Civelli, 2017-03-09 22:53:54]

jcivelli@chromium.org changed reviewers:
+ bradnelson@chromium.org

[Jay Civelli, 2017-03-09 22:54:53]

TBRing bradnelson@ for trivial caller site change in components/nacl

[Jay Civelli, 2017-03-09 22:54:59]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-09 22:55:00]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
lhchavez@chromium.org, jam@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2738853002/#ps280001
(title: "Fix Win release build.")

[commit-bot: I haz the power, 2017-03-09 22:55:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 00:28:47]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1489100099969740,
"parent_rev": "ef46751e3104cdf54577935780a6c13aa008ff9a", "commit_rev":
"aba5a6139d8823893880402cf40e9f319f2f0a97"}

[commit-bot: I haz the power, 2017-03-10 00:29:32]

Description was changed from

==========
Changing connections to take a ConnectionParams instead of a pipe handle.
ConnectionParams will be augmented in a follow up patch to take extra
objects on Android (channels to support sending Parcelable instances).

BUG=699311
TBR=jam@chromium.org,sky@chromium.org,lhchavez@chromium.org,bradnelson@chromi...
==========

to

==========
Changing connections to take a ConnectionParams instead of a pipe handle.
ConnectionParams will be augmented in a follow up patch to take extra
objects on Android (channels to support sending Parcelable instances).

BUG=699311
TBR=jam@chromium.org,sky@chromium.org,lhchavez@chromium.org,bradnelson@chromi...

Review-Url: https://codereview.chromium.org/2738853002
Cr-Commit-Position: refs/heads/master@{#455921}
Committed:
https://chromium.googlesource.com/chromium/src/+/aba5a6139d8823893880402cf40e...
==========

[commit-bot: I haz the power, 2017-03-10 00:29:35]

Committed patchset #8 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/aba5a6139d8823893880402cf40e...