mojo/edk/embedder/embedder_unittest.cc - Issue 2738853002: Connections now take a ConnectionParams instead of a pipe handle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/embedder/embedder_unittest.cc

Issue 2738853002: Connections now take a ConnectionParams instead of a pipe handle. (Closed)

Patch Set: Fix Win release build. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/edk/embedder/embedder_unittest.cc

diff --git a/mojo/edk/embedder/embedder_unittest.cc b/mojo/edk/embedder/embedder_unittest.cc

index 2eb6bebb9deb53ca539dfb5c9dab69a6e5e5f9a8..d5a87e54f99b96e238ac97de39be7944f6928ae2 100644

--- a/mojo/edk/embedder/embedder_unittest.cc

+++ b/mojo/edk/embedder/embedder_unittest.cc

@@ -210,7 +210,8 @@ TEST_F(EmbedderTest, PipeSetup_LaunchDeath) {

PendingProcessConnection process;

std::string pipe_token;

ScopedMessagePipeHandle parent_mp = process.CreateMessagePipe(&pipe_token);

- process.Connect(base::GetCurrentProcessHandle(), pair.PassServerHandle());

+ process.Connect(base::GetCurrentProcessHandle(),

+ ConnectionParams(pair.PassServerHandle()));

// Close the remote end, simulating child death before the child connects to

// the reserved port.

« no previous file with comments | « mojo/edk/embedder/embedder.cc ('k') | mojo/edk/embedder/pending_process_connection.h » ('j') | no next file with comments »