components/nacl/broker/nacl_broker_listener.cc - Issue 2738853002: Connections now take a ConnectionParams instead of a pipe handle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/broker/nacl_broker_listener.cc

Issue 2738853002: Connections now take a ConnectionParams instead of a pipe handle. (Closed)

Patch Set: Fix Win release build. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/broker/nacl_broker_listener.cc

diff --git a/components/nacl/broker/nacl_broker_listener.cc b/components/nacl/broker/nacl_broker_listener.cc

index 734e5e5d93298a9ad26118ac170f915d6f758d8e..abd72aeb0e2c83af1774a61b9fd2405d7531a5f3 100644

--- a/components/nacl/broker/nacl_broker_listener.cc

+++ b/components/nacl/broker/nacl_broker_listener.cc

@@ -149,8 +149,9 @@ void NaClBrokerListener::OnLaunchLoaderThroughBroker(

this, cmd_line, handles, &loader_process);

if (result == sandbox::SBOX_ALL_OK) {

- pending_process.Connect(loader_process.Handle(),

- std::move(parent_handle));

+ pending_process.Connect(

+ loader_process.Handle(),

+ mojo::edk::ConnectionParams(std::move(parent_handle)));

// Note: PROCESS_DUP_HANDLE is necessary here, because:

// 1) The current process is the broker, which is the loader's parent.

« no previous file with comments | « components/arc/arc_session.cc ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »