[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed

[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed

Ignore an URL when the URL does not have typed visit.

BUG=686775
previously, synced_typed_urls_.insert new url before or after
AddTypedUrlToChangeList, now I move this into AddTypedUrlToChangeList.

Review-Url: https://codereview.chromium.org/2738843002
Cr-Commit-Position: refs/heads/master@{#455604}
Committed: https://chromium.googlesource.com/chromium/src/+/3d4ced0b8d7081318da910aff495ed4f5f38f63e

[Gang Wu, 2017-03-08 00:18:35]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 00:19:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gang Wu, 2017-03-08 00:29:21]

Description was changed from

==========
final


ignore no typed url

BUG=
==========

to

==========
[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed

Ignore an URL when the URL does not have typed visit

BUG=686775
==========

[Gang Wu, 2017-03-08 00:29:21]

gangwu@chromium.org changed reviewers:
+ zea@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:45:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:45:52]

Dry run: This issue passed the CQ dry run.

[Gang Wu, 2017-03-08 19:49:21]

Patchset #2 (id:20001) has been deleted

[Gang Wu, 2017-03-08 19:53:18]

Description was changed from

==========
[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed

Ignore an URL when the URL does not have typed visit

BUG=686775
==========

to

==========
[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed

Ignore an URL when the URL does not have typed visit

BUG=686775

previously, synced_typed_urls_.insert new url before or after
AddTypedUrlToChangeList, now I move this into AddTypedUrlToChangeList.
==========

[Gang Wu, 2017-03-08 19:53:44]

PTAL

[Nicolas Zea, 2017-03-08 22:22:39]

LGTM with nits

https://codereview.chromium.org/2738843002/diff/40001/components/history/core...
File components/history/core/browser/typed_url_syncable_service.cc (right):

https://codereview.chromium.org/2738843002/diff/40001/components/history/core...
components/history/core/browser/typed_url_syncable_service.cc:876: // This URL
has no TYPED visits, don't sync it
nit: this body should be within curly braces (multi-line if statement)

https://codereview.chromium.org/2738843002/diff/40001/components/history/core...
File components/history/core/browser/typed_url_syncable_service.h (right):

https://codereview.chromium.org/2738843002/diff/40001/components/history/core...
components/history/core/browser/typed_url_syncable_service.h:74: // return true
if this function successfully converts the passed URL
nit: capitalize first letter in sentence.

[Gang Wu, 2017-03-08 22:40:49]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 22:41:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 23:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 23:45:36]

Dry run: This issue passed the CQ dry run.

[Gang Wu, 2017-03-09 00:06:22]

updated

https://codereview.chromium.org/2738843002/diff/40001/components/history/core...
File components/history/core/browser/typed_url_syncable_service.cc (right):

https://codereview.chromium.org/2738843002/diff/40001/components/history/core...
components/history/core/browser/typed_url_syncable_service.cc:876: // This URL
has no TYPED visits, don't sync it
On 2017/03/08 22:22:39, Nicolas Zea wrote:
> nit: this body should be within curly braces (multi-line if statement)

Done.

https://codereview.chromium.org/2738843002/diff/40001/components/history/core...
File components/history/core/browser/typed_url_syncable_service.h (right):

https://codereview.chromium.org/2738843002/diff/40001/components/history/core...
components/history/core/browser/typed_url_syncable_service.h:74: // return true
if this function successfully converts the passed URL
On 2017/03/08 22:22:39, Nicolas Zea wrote:
> nit: capitalize first letter in sentence.

Done.

[Gang Wu, 2017-03-09 00:06:27]

The CQ bit was checked by gangwu@chromium.org

[Gang Wu, 2017-03-09 00:06:28]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/2738843002/#ps60001
(title: "nit update")

[commit-bot: I haz the power, 2017-03-09 00:07:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 00:13:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489017987787820,
"parent_rev": "043b638699e0d9854aa53dfc0eeac1f8b7be16b4", "commit_rev":
"3d4ced0b8d7081318da910aff495ed4f5f38f63e"}

[commit-bot: I haz the power, 2017-03-09 00:14:26]

Description was changed from

==========
[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed

Ignore an URL when the URL does not have typed visit

BUG=686775

previously, synced_typed_urls_.insert new url before or after
AddTypedUrlToChangeList, now I move this into AddTypedUrlToChangeList.
==========

to

==========
[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed

Ignore an URL when the URL does not have typed visit

BUG=686775

previously, synced_typed_urls_.insert new url before or after
AddTypedUrlToChangeList, now I move this into AddTypedUrlToChangeList.

Review-Url: https://codereview.chromium.org/2738843002
Cr-Commit-Position: refs/heads/master@{#455604}
Committed:
https://chromium.googlesource.com/chromium/src/+/3d4ced0b8d7081318da910aff495...
==========

[commit-bot: I haz the power, 2017-03-09 00:14:30]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3d4ced0b8d7081318da910aff495...

[Gang Wu, 2017-09-07 17:41:05]

Description was changed from

==========
[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed

Ignore an URL when the URL does not have typed visit

BUG=686775

previously, synced_typed_urls_.insert new url before or after
AddTypedUrlToChangeList, now I move this into AddTypedUrlToChangeList.

Review-Url: https://codereview.chromium.org/2738843002
Cr-Commit-Position: refs/heads/master@{#455604}
Committed:
https://chromium.googlesource.com/chromium/src/+/3d4ced0b8d7081318da910aff495...
==========

to

==========
[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed

Ignore an URL when the URL does not have typed visit.

BUG=686775

previously, synced_typed_urls_.insert new url before or after
AddTypedUrlToChangeList, now I move this into AddTypedUrlToChangeList.

Review-Url: https://codereview.chromium.org/2738843002
Cr-Commit-Position: refs/heads/master@{#455604}
Committed:
https://chromium.googlesource.com/chromium/src/+/3d4ced0b8d7081318da910aff495...
==========