Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2738843002: [Sync] Sync do not sync Typed URL when updating an URL that wasn't typed (Closed)

Created:
3 years, 9 months ago by Gang Wu
Modified:
3 years, 3 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed Ignore an URL when the URL does not have typed visit. BUG=686775 previously, synced_typed_urls_.insert new url before or after AddTypedUrlToChangeList, now I move this into AddTypedUrlToChangeList. Review-Url: https://codereview.chromium.org/2738843002 Cr-Commit-Position: refs/heads/master@{#455604} Committed: https://chromium.googlesource.com/chromium/src/+/3d4ced0b8d7081318da910aff495ed4f5f38f63e

Patch Set 1 #

Patch Set 2 : update comments #

Total comments: 4

Patch Set 3 : nit update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -45 lines) Patch
M components/browser_sync/profile_sync_service_typed_url_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/history/core/browser/typed_url_syncable_service.h View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M components/history/core/browser/typed_url_syncable_service.cc View 1 2 8 chunks +20 lines, -25 lines 0 comments Download
M components/history/core/browser/typed_url_syncable_service_unittest.cc View 1 4 chunks +31 lines, -14 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
Gang Wu
PTAL
3 years, 9 months ago (2017-03-08 19:53:44 UTC) #9
Nicolas Zea
LGTM with nits https://codereview.chromium.org/2738843002/diff/40001/components/history/core/browser/typed_url_syncable_service.cc File components/history/core/browser/typed_url_syncable_service.cc (right): https://codereview.chromium.org/2738843002/diff/40001/components/history/core/browser/typed_url_syncable_service.cc#newcode876 components/history/core/browser/typed_url_syncable_service.cc:876: // This URL has no TYPED ...
3 years, 9 months ago (2017-03-08 22:22:39 UTC) #10
Gang Wu
updated https://codereview.chromium.org/2738843002/diff/40001/components/history/core/browser/typed_url_syncable_service.cc File components/history/core/browser/typed_url_syncable_service.cc (right): https://codereview.chromium.org/2738843002/diff/40001/components/history/core/browser/typed_url_syncable_service.cc#newcode876 components/history/core/browser/typed_url_syncable_service.cc:876: // This URL has no TYPED visits, don't ...
3 years, 9 months ago (2017-03-09 00:06:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738843002/60001
3 years, 9 months ago (2017-03-09 00:07:31 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 00:14:30 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3d4ced0b8d7081318da910aff495...

Powered by Google App Engine
This is Rietveld 408576698