Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: components/history/core/browser/typed_url_syncable_service.h

Issue 2738843002: [Sync] Sync do not sync Typed URL when updating an URL that wasn't typed (Closed)
Patch Set: nit update Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/typed_url_syncable_service.h
diff --git a/components/history/core/browser/typed_url_syncable_service.h b/components/history/core/browser/typed_url_syncable_service.h
index 838e83efc6d77e07b97a08a165974e9d6dcc6886..2cbc0c26bdf690fa98bdc3e452ba22dd0636b44e 100644
--- a/components/history/core/browser/typed_url_syncable_service.h
+++ b/components/history/core/browser/typed_url_syncable_service.h
@@ -71,11 +71,12 @@ class TypedUrlSyncableService : public syncer::SyncableService,
// Returns the percentage of DB accesses that have resulted in an error.
int GetErrorPercentage() const;
- // Converts the passed URL information to a TypedUrlSpecifics structure for
- // writing to the sync DB.
- static void WriteToTypedUrlSpecifics(const URLRow& url,
+ // Return true if this function successfully converts the passed URL
+ // information to a TypedUrlSpecifics structure for writing to the sync DB.
+ static bool WriteToTypedUrlSpecifics(const URLRow& url,
const VisitVector& visits,
- sync_pb::TypedUrlSpecifics* specifics);
+ sync_pb::TypedUrlSpecifics* specifics)
+ WARN_UNUSED_RESULT;
private:
friend class TypedUrlSyncableServiceTest;

Powered by Google App Engine
This is Rietveld 408576698