Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: components/browser_sync/profile_sync_service_typed_url_unittest.cc

Issue 2738843002: [Sync] Sync do not sync Typed URL when updating an URL that wasn't typed (Closed)
Patch Set: nit update Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/history/core/browser/typed_url_syncable_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_sync/profile_sync_service_typed_url_unittest.cc
diff --git a/components/browser_sync/profile_sync_service_typed_url_unittest.cc b/components/browser_sync/profile_sync_service_typed_url_unittest.cc
index 440cd85be7eee83edb3310033148a48d25027ea7..db7db211a5e03d8ab285151e43fe24e783687bd4 100644
--- a/components/browser_sync/profile_sync_service_typed_url_unittest.cc
+++ b/components/browser_sync/profile_sync_service_typed_url_unittest.cc
@@ -144,7 +144,7 @@ class TestTypedUrlSyncableService : public TypedUrlSyncableService {
const history::VisitVector& visits,
syncer::WriteNode* node) {
sync_pb::TypedUrlSpecifics typed_url;
- WriteToTypedUrlSpecifics(url, visits, &typed_url);
+ ASSERT_TRUE(WriteToTypedUrlSpecifics(url, visits, &typed_url));
node->SetTypedUrlSpecifics(typed_url);
}
@@ -393,7 +393,7 @@ void AddTypedUrlEntries(ProfileSyncServiceTypedUrlTest* test,
for (size_t i = 0; i < entries.size(); ++i) {
history::VisitVector visits;
visits.push_back(history::VisitRow(entries[i].id(), entries[i].last_visit(),
- 0, ui::PageTransitionFromInt(0), 0));
+ 0, ui::PageTransitionFromInt(1), 0));
test->AddTypedUrlSyncNode(entries[i], visits);
}
}
« no previous file with comments | « no previous file | components/history/core/browser/typed_url_syncable_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698