Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2738773002: DevTools: [Bindings] add resources to every frame. (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Bindings] add resources to every frame. This patch starts adding UISourceCodes for every frame, which aligns with our behavior for stylesheets and scripts. BUG=670180 R=dgozman Review-Url: https://codereview.chromium.org/2738773002 Cr-Commit-Position: refs/heads/master@{#455585} Committed: https://chromium.googlesource.com/chromium/src/+/a7852b75fa1cd5e90d2aed4cf612e4058e4604e6

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : rebaseline tests #

Messages

Total messages: 15 (11 generated)
lushnikov
please, take a look https://codereview.chromium.org/2738773002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt File third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt (right): https://codereview.chromium.org/2738773002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt#newcode10 third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt:10: 1) onXhrLoad (resources/child.html:12) This change ...
3 years, 9 months ago (2017-03-07 19:36:45 UTC) #1
dgozman
Nice one! lgtm
3 years, 9 months ago (2017-03-07 20:08:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738773002/40001
3 years, 9 months ago (2017-03-08 21:42:26 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 23:16:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a7852b75fa1cd5e90d2aed4cf612...

Powered by Google App Engine
This is Rietveld 408576698