Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2738033002: DevTools: add more tests to fixate bindings behavior (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add more tests to fixate bindings behavior NetworkProject's cleanup logic currently relies on resources in resourceTreeFrame. This patch adds tests with scripts and stylesheets which don't have underlying resource: - contentscript-* tests validate bindings creating and removing UISourceCodes for content scripts - dynamic-* tests validate bindings creating and removing UISourceCodes for dynamically-created styles As a drive-by, the patch improves the InspectorTest.dumpWorkspace() method to also produce a diff with the previous workspace dump. This helps to read expectations a lot. R=dgozman BUG=670180 Review-Url: https://codereview.chromium.org/2738033002 Cr-Commit-Position: refs/heads/master@{#455973} Committed: https://chromium.googlesource.com/chromium/src/+/074f0c4a4ad0b9cf594780b34bde720f57a177b8

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -87 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-frame-attach-detach.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-frame-attach-detach-expected.txt View 3 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-frame-navigate.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-frame-navigate-expected.txt View 3 chunks +15 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-main-frame-navigated.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-main-frame-navigated-expected.txt View 1 2 chunks +28 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-multiple-frames.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-multiple-frames-expected.txt View 5 chunks +26 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js View 2 chunks +30 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/contentscripts-bindings-multiple-frames.html View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/contentscripts-bindings-multiple-frames-expected.txt View 1 chunk +102 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/contentscripts-navigator-multiple-frames.html View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/contentscripts-navigator-multiple-frames-expected.txt View 1 chunk +25 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector/bindings/dynamic-bindings-frame-attach-detach.html View 2 chunks +6 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/dynamic-bindings-frame-attach-detach-expected.txt View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/dynamic-navigator-frame-attach-detach.html View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/dynamic-navigator-frame-attach-detach-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/contentscript-frame.html View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/dynamic-frame.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/sourcemap-bindings-multiple-frames.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/sourcemap-bindings-multiple-frames-expected.txt View 6 chunks +29 lines, -19 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-08 23:05:25 UTC) #1
dgozman
lgtm
3 years, 9 months ago (2017-03-09 23:22:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738033002/1
3 years, 9 months ago (2017-03-10 01:26:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/324483) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-10 01:30:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738033002/20001
3 years, 9 months ago (2017-03-10 01:55:28 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 03:07:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/074f0c4a4ad0b9cf594780b34bde...

Powered by Google App Engine
This is Rietveld 408576698