Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 2731403009: DevTools: add tests to fixate sourcemap bindings behavior (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add tests to fixate sourcemap bindings behavior These tests fixate how source map bindings, such as CompilerScriptMapping and SASSSourceMapping, produce sources correctly for frames. As these tests reveal, CompilerScriptMapping currently doesn't attach sources for all frames. BUG=670180, 685552 R=dgozman Review-Url: https://codereview.chromium.org/2731403009 Cr-Commit-Position: refs/heads/master@{#455547} Committed: https://chromium.googlesource.com/chromium/src/+/95ff5bc751ba619a7c37155eec85c1adcadb01bc

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-main-frame-navigated.html View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-main-frame-navigated-expected.txt View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/navigator-main-frame-navigated.html View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/navigator-main-frame-navigated-expected.txt View 1 chunk +6 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/sourcemap-frame.html View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/sourcemap-sass.scss View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/sourcemap-script.js View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/sourcemap-script.js.map View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/sourcemap-style.css View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/sourcemap-style.css.map View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/sourcemap-typescript.ts View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/sourcemap-bindings-multiple-frames.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/sourcemap-bindings-multiple-frames-expected.txt View 1 chunk +88 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/sourcemap-navigator-multiple-frames.html View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/sourcemap-navigator-multiple-frames-expected.txt View 1 chunk +90 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js View 2 chunks +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-08 18:17:44 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2731403009/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js (right): https://codereview.chromium.org/2731403009/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js#newcode73 third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js:73: sourceMapCallbacks.delete(urlSuffix); nit: delete callback before calling it for ...
3 years, 9 months ago (2017-03-08 19:07:09 UTC) #6
lushnikov
https://codereview.chromium.org/2731403009/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js (right): https://codereview.chromium.org/2731403009/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js#newcode73 third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js:73: sourceMapCallbacks.delete(urlSuffix); On 2017/03/08 19:07:09, dgozman wrote: > nit: delete ...
3 years, 9 months ago (2017-03-08 21:33:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731403009/20001
3 years, 9 months ago (2017-03-08 21:33:47 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 21:41:12 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/95ff5bc751ba619a7c37155eec85...

Powered by Google App Engine
This is Rietveld 408576698