Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 273873002: Blink GC plugin: require a trace method if a class derives multiple bases that need tracing. (Closed)

Created:
6 years, 7 months ago by zerny-chromium
Modified:
6 years, 7 months ago
CC:
chromium-reviews, oilpan-reviews
Visibility:
Public.

Description

Blink GC plugin: require a trace method if a class derives multiple bases that need tracing. BUG=334149 R=haraken@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269764

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -26 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 5 chunks +23 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.cpp View 1 1 chunk +9 lines, -1 line 0 comments Download
A + tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.h View 1 chunk +9 lines, -9 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.cpp View 1 1 chunk +5 lines, -8 lines 0 comments Download
A tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/class_requires_trace_method_tmpl.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/stack_allocated.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
zerny-chromium
6 years, 7 months ago (2014-05-08 10:42:42 UTC) #1
wibling-chromium
lgtm
6 years, 7 months ago (2014-05-08 12:53:25 UTC) #2
haraken
LGTM
6 years, 7 months ago (2014-05-08 12:55:16 UTC) #3
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-12 11:02:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/273873002/20001
6 years, 7 months ago (2014-05-12 11:02:18 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 11:03:09 UTC) #6
Message was sent while issue was closed.
Change committed as 269764

Powered by Google App Engine
This is Rietveld 408576698