tools/clang/blink_gc_plugin/RecordInfo.h - Issue 273873002: Blink GC plugin: require a trace method if a class derives multiple bases that need tracing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/RecordInfo.h

Issue 273873002: Blink GC plugin: require a trace method if a class derives multiple bases that need tracing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/blink_gc_plugin/RecordInfo.h

diff --git a/tools/clang/blink_gc_plugin/RecordInfo.h b/tools/clang/blink_gc_plugin/RecordInfo.h

index 62080ed5c0147245f9fa3c731bbc38cb41e3adad..5bad7ce9f7964d6935d42094c5d735e22a405df8 100644

--- a/tools/clang/blink_gc_plugin/RecordInfo.h

+++ b/tools/clang/blink_gc_plugin/RecordInfo.h

@@ -38,8 +38,6 @@ class BasePoint : public GraphPoint {

const TracingStatus& status)

: spec_(spec), info_(info), status_(status) {}

const TracingStatus NeedsTracing() { return status_; }

- // Needed to change the status of bases with a pure-virtual trace.

- void MarkUnneeded() { status_ = TracingStatus::Unneeded(); }

const clang::CXXBaseSpecifier& spec() { return spec_; }

RecordInfo* info() { return info_; }

« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp ('k') | tools/clang/blink_gc_plugin/RecordInfo.cpp » ('j') | no next file with comments »