Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.cpp

Issue 273873002: Blink GC plugin: require a trace method if a class derives multiple bases that need tracing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp b/tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.cpp
similarity index 55%
copy from tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp
copy to tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.cpp
index b490fc5e403f0e4cccb76b62c2f640047eb30716..73792bfab163db6c0cdada682c61773a8cc7d601 100644
--- a/tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp
+++ b/tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.cpp
@@ -2,17 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "non_virtual_trace.h"
+#include "class_multiple_trace_bases.h"
namespace WebCore {
-void A::trace(Visitor* visitor)
-{
-}
+void Base::trace(Visitor* visitor) { }
-void C::trace(Visitor* visitor)
-{
- B::trace(visitor);
-}
+void Mixin::trace(Visitor* visitor) { }
+
+// Missing: Derived::trace(visitor)
}

Powered by Google App Engine
This is Rietveld 408576698