tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt - Issue 273873002: Blink GC plugin: require a trace method if a class derives multiple bases that need tracing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

Issue 273873002: Blink GC plugin: require a trace method if a class derives multiple bases that need tracing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt ('k') | tools/clang/blink_gc_plugin/tests/class_requires_trace_method_tmpl.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt b/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

index 7956ca6506c4e6964cb6ae8e5e917f8f84240e0a..de6fd949adda1b2c73e5762bac61a2800f7caea0 100644

--- a/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

@@ -1,11 +1,11 @@

In file included from class_requires_trace_method.cpp:5:

-./class_requires_trace_method.h:14:1: warning: [blink-gc] Class 'PartObject' requires a trace method because it contains fields that require tracing.

+./class_requires_trace_method.h:14:1: warning: [blink-gc] Class 'PartObject' requires a trace method.

class PartObject {

./class_requires_trace_method.h:17:5: note: [blink-gc] Untraced field 'm_obj' declared here:

Member<HeapObject> m_obj;

-./class_requires_trace_method.h:20:1: warning: [blink-gc] Class 'HeapObject' requires a trace method because it contains fields that require tracing.

+./class_requires_trace_method.h:20:1: warning: [blink-gc] Class 'HeapObject' requires a trace method.

class HeapObject : public GarbageCollected<HeapObject> {

./class_requires_trace_method.h:22:5: note: [blink-gc] Untraced field 'm_part' declared here: