[Sync] Enable Sync_integration_tests on chromeos

[Sync] Enable Sync_integration_tests on chromeos

Disable failed tests, will fix them later.

BUG=689662
Review-Url: https://codereview.chromium.org/2738243002
Cr-Commit-Position: refs/heads/master@{#456726}
Committed: https://chromium.googlesource.com/chromium/src/+/c339dcf07a3f5b2b534ead3202db7656389d2bbe

[Gang Wu, 2017-03-09 18:15:42]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 18:16:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 19:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 19:00:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gang Wu, 2017-03-09 22:45:48]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 22:46:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gang Wu, 2017-03-09 22:48:05]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 22:48:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 23:43:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 23:43:32]

Dry run: This issue passed the CQ dry run.

[Gang Wu, 2017-03-10 06:02:14]

Patchset #2 (id:20001) has been deleted

[Gang Wu, 2017-03-10 06:04:58]

Description was changed from

==========
enable on chromeos

BUG=
==========

to

==========
[Sync] Enable Sync_integration_tests on chromeos

Disable failed tests, will fix them later.

BUG=689662
==========

[Gang Wu, 2017-03-10 06:04:58]

gangwu@chromium.org changed reviewers:
+ skym@chromium.org

[Gang Wu, 2017-03-10 06:06:07]

PTAL

[skym, 2017-03-10 18:13:20]

lgtm

https://codereview.chromium.org/2738243002/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/enable_disable_test.cc (right):

https://codereview.chromium.org/2738243002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/enable_disable_test.cc:162: //
http://crbug.com/689662
I'd drop the http://

Also, to me this just looks a little more clean if you move the bug above the
first #if def

[Gang Wu, 2017-03-10 18:51:38]

gangwu@chromium.org changed reviewers:
+ sky@chromium.org

[Gang Wu, 2017-03-10 18:51:39]

updated, sky@, please review for testing/buildbot/chromium.chromiumos.json.

https://codereview.chromium.org/2738243002/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/enable_disable_test.cc (right):

https://codereview.chromium.org/2738243002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/enable_disable_test.cc:162: //
http://crbug.com/689662
On 2017/03/10 18:13:20, skym wrote:
> I'd drop the http://
> 
> Also, to me this just looks a little more clean if you move the bug above the
> first #if def

Done.

[sky, 2017-03-10 20:40:33]

Have you run these on a FYI bot to make sure they are stable?

[Gang Wu, 2017-03-10 22:28:28]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 22:29:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gang Wu, 2017-03-10 22:40:16]

gangwu@chromium.org changed reviewers:
+ dpranke@chromium.org

[Gang Wu, 2017-03-10 23:08:57]

updated cl to add tests to FYI bot.

[commit-bot: I haz the power, 2017-03-10 23:29:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 23:29:47]

Dry run: This issue passed the CQ dry run.

[sky, 2017-03-11 00:11:34]

LGTM - thanks

[Gang Wu, 2017-03-13 21:18:34]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 21:19:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gang Wu, 2017-03-13 22:09:08]

chat with dpranke@, we think it is ok to add the tests to main waterfall since
they are existing tests.

[commit-bot: I haz the power, 2017-03-13 22:29:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 22:29:09]

Dry run: This issue passed the CQ dry run.

[Gang Wu, 2017-03-14 16:22:08]

The CQ bit was checked by gangwu@chromium.org

[Gang Wu, 2017-03-14 16:22:09]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2738243002/#ps100001
(title: "add to main waterfall")

[commit-bot: I haz the power, 2017-03-14 16:23:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 16:29:36]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489508528864570,
"parent_rev": "8401d78afcd1cf80cbe547f597b3bad9edf83694", "commit_rev":
"c339dcf07a3f5b2b534ead3202db7656389d2bbe"}

[commit-bot: I haz the power, 2017-03-14 16:30:22]

Description was changed from

==========
[Sync] Enable Sync_integration_tests on chromeos

Disable failed tests, will fix them later.

BUG=689662
==========

to

==========
[Sync] Enable Sync_integration_tests on chromeos

Disable failed tests, will fix them later.

BUG=689662

Review-Url: https://codereview.chromium.org/2738243002
Cr-Commit-Position: refs/heads/master@{#456726}
Committed:
https://chromium.googlesource.com/chromium/src/+/c339dcf07a3f5b2b534ead3202db...
==========

[commit-bot: I haz the power, 2017-03-14 16:30:23]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c339dcf07a3f5b2b534ead3202db...