chrome/browser/sync/test/integration/single_client_printers_sync_test.cc - Issue 2738243002: [Sync] Enable Sync_integration_tests on chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_printers_sync_test.cc

Issue 2738243002: [Sync] Enable Sync_integration_tests on chromeos (Closed)

Patch Set: add to main waterfall Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/enable_disable_test.cc ('k') | chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_printers_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc b/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc

index 4b41c7e3da990f7a4b52cf7480e2d9da9b44afca..f8f87d97f52f5df7fbbddbed785b65b39632f542 100644

--- a/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc

@@ -79,7 +79,13 @@ IN_PROC_BROWSER_TEST_F(SingleClientPrintersSyncTest, RemovePrinter) {

}

// Verify that merging data added before sync works.

-IN_PROC_BROWSER_TEST_F(SingleClientPrintersSyncTest, AddBeforeSetup) {

+// crbug.com/689662

+#if defined(OS_CHROMEOS)

+#define MAYBE_AddBeforeSetup DISABLED_AddBeforeSetup

+#else

+#define MAYBE_AddBeforeSetup AddBeforeSetup

+#endif

+IN_PROC_BROWSER_TEST_F(SingleClientPrintersSyncTest, MAYBE_AddBeforeSetup) {

ASSERT_TRUE(SetupClients());

AddPrinter(GetPrinterStore(0), printers_helper::CreateTestPrinter(0));