Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: chrome/browser/sync/test/integration/sync_errors_test.cc

Issue 2738243002: [Sync] Enable Sync_integration_tests on chromeos (Closed)
Patch Set: add to main waterfall Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/run_loop.h" 6 #include "base/run_loop.h"
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/sync/test/integration/bookmarks_helper.h" 8 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
9 #include "chrome/browser/sync/test/integration/passwords_helper.h" 9 #include "chrome/browser/sync/test/integration/passwords_helper.h"
10 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h" 10 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 ProfileSyncService::Status status; 140 ProfileSyncService::Status status;
141 GetSyncService(0)->QueryDetailedSyncStatus(&status); 141 GetSyncService(0)->QueryDetailedSyncStatus(&status);
142 ASSERT_EQ(status.sync_protocol_error.error_type, syncer::TRANSIENT_ERROR); 142 ASSERT_EQ(status.sync_protocol_error.error_type, syncer::TRANSIENT_ERROR);
143 ASSERT_EQ(status.sync_protocol_error.action, syncer::UPGRADE_CLIENT); 143 ASSERT_EQ(status.sync_protocol_error.action, syncer::UPGRADE_CLIENT);
144 ASSERT_EQ(status.sync_protocol_error.url, url); 144 ASSERT_EQ(status.sync_protocol_error.url, url);
145 ASSERT_EQ(status.sync_protocol_error.error_description, description); 145 ASSERT_EQ(status.sync_protocol_error.error_description, description);
146 } 146 }
147 147
148 // This test verifies that sync keeps retrying if it encounters error during 148 // This test verifies that sync keeps retrying if it encounters error during
149 // setup. 149 // setup.
150 IN_PROC_BROWSER_TEST_F(SyncErrorTest, ErrorWhileSettingUp) { 150 // crbug.com/689662
151 #if defined(OS_CHROMEOS)
152 #define MAYBE_ErrorWhileSettingUp DISABLED_ErrorWhileSettingUp
153 #else
154 #define MAYBE_ErrorWhileSettingUp ErrorWhileSettingUp
155 #endif
156 IN_PROC_BROWSER_TEST_F(SyncErrorTest, MAYBE_ErrorWhileSettingUp) {
151 ASSERT_TRUE(SetupClients()); 157 ASSERT_TRUE(SetupClients());
152 158
153 #if !defined(OS_CHROMEOS) 159 #if !defined(OS_CHROMEOS)
154 // On non auto start enabled environments if the setup sync fails then 160 // On non auto start enabled environments if the setup sync fails then
155 // the setup would fail. So setup sync normally. 161 // the setup would fail. So setup sync normally.
156 // In contrast on auto start enabled platforms like chrome os we should be 162 // In contrast on auto start enabled platforms like chrome os we should be
157 // able to set up even if the first sync while setting up fails. 163 // able to set up even if the first sync while setting up fails.
158 ASSERT_TRUE(SetupSync()) << "Setup sync failed"; 164 ASSERT_TRUE(SetupSync()) << "Setup sync failed";
159 ASSERT_TRUE(GetClient(0)->DisableSyncForDatatype(syncer::AUTOFILL)); 165 ASSERT_TRUE(GetClient(0)->DisableSyncForDatatype(syncer::AUTOFILL));
160 #endif 166 #endif
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 TypeDisabledChecker(GetSyncService(0), syncer::TYPED_URLS).Wait()); 256 TypeDisabledChecker(GetSyncService(0), syncer::TYPED_URLS).Wait());
251 ASSERT_TRUE(TypeDisabledChecker(GetSyncService(0), syncer::SESSIONS).Wait()); 257 ASSERT_TRUE(TypeDisabledChecker(GetSyncService(0), syncer::SESSIONS).Wait());
252 258
253 const BookmarkNode* node1 = AddFolder(0, 0, "title1"); 259 const BookmarkNode* node1 = AddFolder(0, 0, "title1");
254 SetTitle(0, node1, "new_title1"); 260 SetTitle(0, node1, "new_title1");
255 ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait()); 261 ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
256 // TODO(lipalani): Verify initial sync ended for typed url is false. 262 // TODO(lipalani): Verify initial sync ended for typed url is false.
257 } 263 }
258 264
259 } // namespace 265 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698