Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2738053008: Revert of [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC. (Closed)

Created:
3 years, 9 months ago by baxley
Modified:
3 years, 9 months ago
Reviewers:
stkhapugin, lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, tfarina, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC. (patchset #4 id:60001 of https://codereview.chromium.org/2737603007/ ) Reason for revert: EG bookmarks tests started failing after this CL. Here is the first failure: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/25193 Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Review-Url: https://codereview.chromium.org/2737603007 > Cr-Commit-Position: refs/heads/master@{#456064} > Committed: https://chromium.googlesource.com/chromium/src/+/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a TBR=lpromero@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363 Review-Url: https://codereview.chromium.org/2738053008 Cr-Commit-Position: refs/heads/master@{#456084} Committed: https://chromium.googlesource.com/chromium/src/+/33939c01a9cc0064f9a9a50060af1036c5b86ae1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -238 lines) Patch
M ios/chrome/browser/ui/bookmarks/BUILD.gn View 2 chunks +22 lines, -22 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.mm View 17 chunks +58 lines, -35 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_collection_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm View 13 chunks +36 lines, -25 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm View 3 chunks +7 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.mm View 1 chunk +6 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm View 11 chunks +38 lines, -31 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm View 1 chunk +15 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_extended_button.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm View 5 chunks +8 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm View 12 chunks +51 lines, -47 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm View 3 chunks +17 lines, -18 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm View 13 chunks +34 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
baxley
Created Revert of [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.
3 years, 9 months ago (2017-03-10 16:55:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738053008/1
3 years, 9 months ago (2017-03-10 16:55:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/33939c01a9cc0064f9a9a50060af1036c5b86ae1
3 years, 9 months ago (2017-03-10 16:57:44 UTC) #6
lpromero
3 years, 9 months ago (2017-03-10 17:06:46 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698