Revert of [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.

ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.h"
 
 #include <memory>
 #include <set>
 
 #include "base/auto_reset.h"
 #include "base/ios/block_types.h"
+#include "base/ios/weak_nsobject.h"
 #include "base/logging.h"
 #include "base/mac/bind_objc_block.h"
 #import "base/mac/foundation_util.h"
-
+#include "base/mac/objc_property_releaser.h"
 #include "base/mac/scoped_cftyperef.h"
+#include "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "components/url_formatter/url_fixer.h"
 #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_extended_button.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_model_bridge_observer.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h"
 #import "ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item.h"
 #import "ios/chrome/browser/ui/bookmarks/cells/bookmark_text_field_item.h"
 #import "ios/chrome/browser/ui/collection_view/collection_view_model.h"
 #import "ios/chrome/browser/ui/icons/chrome_icon.h"
 #import "ios/chrome/browser/ui/image_util.h"
 #import "ios/chrome/browser/ui/keyboard/UIKeyCommand+Chrome.h"
 #include "ios/chrome/browser/ui/rtl_geometry.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #include "ios/chrome/grit/ios_strings.h"
 #import "ios/public/provider/chrome/browser/chrome_browser_provider.h"
 #import "ios/public/provider/chrome/browser/ui/text_field_styling.h"
 #import "ios/third_party/material_components_ios/src/components/Palettes/src/MaterialPalettes.h"
 #import "ios/third_party/material_components_ios/src/components/ShadowElevations/src/MaterialShadowElevations.h"
 #import "ios/third_party/material_components_ios/src/components/ShadowLayer/src/MaterialShadowLayer.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/gfx/image/image.h"
 #include "url/gurl.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 using bookmarks::BookmarkModel;
 using bookmarks::BookmarkNode;
 
 namespace {
 // Converts NSString entered by the user to a GURL.
 GURL ConvertUserDataToGURL(NSString* urlString) {
   if (urlString) {
     return url_formatter::FixupURL(base::SysNSStringToUTF8(urlString),
                                    std::string());
   } else {
@@ skipping 13 matching lines @@
 }  // namespace
 
 @interface BookmarkEditViewController ()<BookmarkFolderViewControllerDelegate,
                                          BookmarkModelBridgeObserver,
                                          BookmarkTextFieldItemDelegate,
                                          TextFieldValidation> {
   // Flag to ignore bookmark model changes notifications.
   BOOL _ignoresBookmarkModelChanges;
 
   std::unique_ptr<bookmarks::BookmarkModelBridge> _modelBridge;
+
+  base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkEditViewController;
 }
 
 // The bookmark this controller displays or edits.
 // Redefined to be readwrite.
 @property(nonatomic, assign) const BookmarkNode* bookmark;
 
 // Reference to the bookmark model.
 @property(nonatomic, assign) BookmarkModel* bookmarkModel;
 
 // The parent of the bookmark. This may be different from |bookmark->parent()|
 // if the changes have not been saved yet. |folder| then represents the
 // candidate for the new parent of |bookmark|.  This property is always a
 // non-NULL, valid folder.
 @property(nonatomic, assign) const BookmarkNode* folder;
 
 // The folder picker view controller.
 // Redefined to be readwrite.
-@property(nonatomic, strong) BookmarkFolderViewController* folderViewController;
+@property(nonatomic, retain) BookmarkFolderViewController* folderViewController;
 
 @property(nonatomic, assign) ios::ChromeBrowserState* browserState;
 
 // Cancel button item in navigation bar.
-@property(nonatomic, strong) UIBarButtonItem* cancelItem;
+@property(nonatomic, retain) UIBarButtonItem* cancelItem;
 
 // Done button item in navigation bar.
-@property(nonatomic, strong) UIBarButtonItem* doneItem;
+@property(nonatomic, retain) UIBarButtonItem* doneItem;
 
 // CollectionViewItem-s from the collection.
-@property(nonatomic, strong) BookmarkTextFieldItem* nameItem;
-@property(nonatomic, strong) BookmarkParentFolderItem* folderItem;
-@property(nonatomic, strong) BookmarkTextFieldItem* URLItem;
+@property(nonatomic, retain) BookmarkTextFieldItem* nameItem;
+@property(nonatomic, retain) BookmarkParentFolderItem* folderItem;
+@property(nonatomic, retain) BookmarkTextFieldItem* URLItem;
 
 // Reports the changes to the delegate, that has the responsibility to save the
 // bookmark.
 - (void)commitBookmarkChanges;
 
 // Changes |self.folder| and updates the UI accordingly.
 // The change is not committed until the user taps the Save button.
 - (void)changeFolder:(const BookmarkNode*)folder;
 
 // The Save button is disabled if the form values are deemed non-valid. This
@@ skipping 37 matching lines @@
 @synthesize URLItem = _URLItem;
 
 #pragma mark - Lifecycle
 
 - (instancetype)initWithBookmark:(const BookmarkNode*)bookmark
                     browserState:(ios::ChromeBrowserState*)browserState {
   DCHECK(bookmark);
   DCHECK(browserState);
   self = [super initWithStyle:CollectionViewControllerStyleAppBar];
   if (self) {
+    _propertyReleaser_BookmarkEditViewController.Init(
+        self, [BookmarkEditViewController class]);
     DCHECK(!bookmark->is_folder());
     DCHECK(!browserState->IsOffTheRecord());
     _bookmark = bookmark;
     _bookmarkModel =
         ios::BookmarkModelFactory::GetForBrowserState(browserState);
 
     _folder = bookmark->parent();
 
     // Set up the bookmark model oberver.
     _modelBridge.reset(
         new bookmarks::BookmarkModelBridge(self, _bookmarkModel));
 
     _browserState = browserState;
   }
   return self;
 }
 
 - (void)dealloc {
   _folderViewController.delegate = nil;
+  [super dealloc];
 }
 
 #pragma mark View lifecycle
 
 - (void)viewDidLoad {
   [super viewDidLoad];
   self.collectionView.backgroundColor = [UIColor whiteColor];
   self.view.accessibilityIdentifier = @"Single Bookmark Editor";
 
   self.title = l10n_util::GetNSString(IDS_IOS_BOOKMARK_EDIT_SCREEN_TITLE);
 
   self.navigationItem.hidesBackButton = YES;
 
   UIBarButtonItem* cancelItem =
       [ChromeIcon templateBarButtonItemWithImage:[ChromeIcon closeIcon]
                                           target:self
                                           action:@selector(cancel)];
   cancelItem.accessibilityIdentifier = @"Cancel";
   self.navigationItem.leftBarButtonItem = cancelItem;
   self.cancelItem = cancelItem;
 
-  UIBarButtonItem* doneItem = [[UIBarButtonItem alloc]
+  base::scoped_nsobject<UIBarButtonItem> doneItem([[UIBarButtonItem alloc]
       initWithTitle:l10n_util::GetNSString(IDS_IOS_BOOKMARK_DONE_BUTTON)
               style:UIBarButtonItemStylePlain
              target:self
-             action:@selector(save)];
-  doneItem.accessibilityIdentifier = @"Done";
+             action:@selector(save)]);
+  doneItem.get().accessibilityIdentifier = @"Done";
   self.navigationItem.rightBarButtonItem = doneItem;
   self.doneItem = doneItem;
 
-  BookmarksElevatedToolbar* buttonBar = [[BookmarksElevatedToolbar alloc] init];
-  UIBarButtonItem* deleteItem = [[UIBarButtonItem alloc]
+  base::scoped_nsobject<BookmarksElevatedToolbar> buttonBar(
+      [[BookmarksElevatedToolbar alloc] init]);
+  base::scoped_nsobject<UIBarButtonItem> deleteItem([[UIBarButtonItem alloc]
       initWithTitle:l10n_util::GetNSString(IDS_IOS_BOOKMARK_DELETE)
               style:UIBarButtonItemStylePlain
              target:self
-             action:@selector(deleteBookmark)];
-  deleteItem.accessibilityIdentifier = @"Delete_action";
+             action:@selector(deleteBookmark)]);
+  deleteItem.get().accessibilityIdentifier = @"Delete_action";
   [deleteItem setTitleTextAttributes:@{
     NSForegroundColorAttributeName : [UIColor blackColor]
   }
                             forState:UIControlStateNormal];
-  [buttonBar.layer addSublayer:[[MDCShadowLayer alloc] init]];
-  buttonBar.shadowElevation = MDCShadowElevationSearchBarResting;
-  buttonBar.backgroundColor = [UIColor whiteColor];
-  buttonBar.items = @[ deleteItem ];
+  [buttonBar.get().layer
+      addSublayer:[[[MDCShadowLayer alloc] init] autorelease]];
+  buttonBar.get().shadowElevation = MDCShadowElevationSearchBarResting;
+  buttonBar.get().backgroundColor = [UIColor whiteColor];
+  buttonBar.get().items = @[ deleteItem ];
   [self.view addSubview:buttonBar];
 
   // Constraint |buttonBar| to be in bottom
-  buttonBar.translatesAutoresizingMaskIntoConstraints = NO;
+  buttonBar.get().translatesAutoresizingMaskIntoConstraints = NO;
   [self.view addConstraints:
                  [NSLayoutConstraint
                      constraintsWithVisualFormat:@"H:|[buttonBar]|"
                                          options:0
                                          metrics:nil
                                            views:NSDictionaryOfVariableBindings(
                                                      buttonBar)]];
   [self.view addConstraint:[NSLayoutConstraint
                                constraintWithItem:buttonBar
                                         attribute:NSLayoutAttributeBottom
@@ skipping 87 matching lines @@
 - (void)updateUIFromBookmark {
   // If there is no current bookmark, don't update.
   if (!self.bookmark)
     return;
 
   [self loadModel];
   CollectionViewModel* model = self.collectionViewModel;
 
   [model addSectionWithIdentifier:SectionIdentifierInfo];
 
-  self.nameItem = [[BookmarkTextFieldItem alloc] initWithType:ItemTypeName];
+  self.nameItem =
+      [[[BookmarkTextFieldItem alloc] initWithType:ItemTypeName] autorelease];
   self.nameItem.accessibilityIdentifier = @"Title Field";
   self.nameItem.placeholder =
       l10n_util::GetNSString(IDS_IOS_BOOKMARK_NAME_FIELD_HEADER);
   self.nameItem.text = bookmark_utils_ios::TitleForBookmarkNode(self.bookmark);
   self.nameItem.delegate = self;
   [model addItem:self.nameItem toSectionWithIdentifier:SectionIdentifierInfo];
 
-  self.folderItem =
-      [[BookmarkParentFolderItem alloc] initWithType:ItemTypeFolder];
+  self.folderItem = [[[BookmarkParentFolderItem alloc]
+      initWithType:ItemTypeFolder] autorelease];
   self.folderItem.title = bookmark_utils_ios::TitleForBookmarkNode(self.folder);
   [model addItem:self.folderItem toSectionWithIdentifier:SectionIdentifierInfo];
 
-  self.URLItem = [[BookmarkTextFieldItem alloc] initWithType:ItemTypeURL];
+  self.URLItem =
+      [[[BookmarkTextFieldItem alloc] initWithType:ItemTypeURL] autorelease];
   self.URLItem.accessibilityIdentifier = @"URL Field";
   self.URLItem.placeholder =
       l10n_util::GetNSString(IDS_IOS_BOOKMARK_URL_FIELD_HEADER);
   self.URLItem.text = base::SysUTF8ToNSString(self.bookmark->url().spec());
   self.URLItem.delegate = self;
   [model addItem:self.URLItem toSectionWithIdentifier:SectionIdentifierInfo];
 
   // Save button state.
   [self updateSaveButtonState];
 }
@@ skipping 26 matching lines @@
   }
   [self.delegate bookmarkEditorWantsDismissal:self];
 }
 
 - (void)moveBookmark {
   DCHECK(self.bookmarkModel);
   DCHECK(!self.folderViewController);
 
   std::set<const BookmarkNode*> editedNodes;
   editedNodes.insert(self.bookmark);
-  BookmarkFolderViewController* folderViewController =
+  base::scoped_nsobject<BookmarkFolderViewController> folderViewController(
       [[BookmarkFolderViewController alloc]
           initWithBookmarkModel:self.bookmarkModel
                allowsNewFolders:YES
                     editedNodes:editedNodes
                    allowsCancel:NO
-                 selectedFolder:self.folder];
-  folderViewController.delegate = self;
+                 selectedFolder:self.folder]);
+  folderViewController.get().delegate = self;
   self.folderViewController = folderViewController;
 
   [self.navigationController pushViewController:self.folderViewController
                                        animated:YES];
 }
 
 - (void)cancel {
   [self dismiss];
 }
 
@@ skipping 145 matching lines @@
   if (!self.bookmarkModel->is_permanent_node(self.folder)) {
     [self changeFolder:self.bookmarkModel->mobile_node()];
   }
 
   [self.delegate bookmarkEditorWantsDismissal:self];
 }
 
 #pragma mark - UIResponder
 
 - (NSArray*)keyCommands {
-  __weak BookmarkEditViewController* weakSelf = self;
+  base::WeakNSObject<BookmarkEditViewController> weakSelf(self);
   return @[ [UIKeyCommand cr_keyCommandWithInput:UIKeyInputEscape
                                    modifierFlags:Cr_UIKeyModifierNone
                                            title:nil
                                           action:^{
                                             [weakSelf dismiss];
                                           }] ];
 }
 
 @end