Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 2738043002: [Mac] Fullscreen Toolbar Fixes (Closed)

Created:
3 years, 9 months ago by spqchan
Modified:
3 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fullscreen Toolbar Fixes - Fixed the layout issues with the fullscreen toolbar - Fixed the hiding animation BUG=689115 Review-Url: https://codereview.chromium.org/2738043002 Cr-Commit-Position: refs/heads/master@{#456117} Committed: https://chromium.googlesource.com/chromium/src/+/e86cff1a78d3b1f75b454487afee3101d3504519

Patch Set 1 #

Patch Set 2 : Cleaned up #

Patch Set 3 : Fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
spqchan
PTAL
3 years, 9 months ago (2017-03-10 18:09:19 UTC) #10
Avi (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-10 18:33:28 UTC) #11
spqchan
On 2017/03/10 18:33:28, Avi wrote: > lgtm thanks!
3 years, 9 months ago (2017-03-10 18:46:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738043002/40001
3 years, 9 months ago (2017-03-10 18:47:01 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 18:53:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e86cff1a78d3b1f75b454487afee...

Powered by Google App Engine
This is Rietveld 408576698