Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2738043002: [Mac] Fullscreen Toolbar Fixes (Closed)
Patch Set: Fixed test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 3c12b1ca3310922539920a89431369126990d677..a95e21b64b6382618001255f03f5ec6fab4546d9 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1031,11 +1031,7 @@ bool IsTabDetachingInFullscreenEnabled() {
manager->DisplayPendingRequests();
}
- // If the web contents want to focus on the location bar, do not call the
- // animation since the location bar will drop down when it's focused.
- bool willFocusLocationBar =
- newContents && newContents->FocusLocationBarByDefault();
- if ([self isInAnyFullscreenMode] && !willFocusLocationBar)
+ if ([self isInAnyFullscreenMode])
[[self fullscreenToolbarController] revealToolbarForTabStripChanges];
}
@@ -1476,10 +1472,8 @@ bool IsTabDetachingInFullscreenEnabled() {
}
- (void)onTabInsertedInForeground:(BOOL)inForeground {
- if ([self isInAnyFullscreenMode] && !inForeground &&
- ![toolbarController_ isLocationBarFocused]) {
+ if ([self isInAnyFullscreenMode] && !inForeground)
[[self fullscreenToolbarController] revealToolbarForTabStripChanges];
- }
}
- (void)userChangedTheme {
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698