Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3021)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 2738043002: [Mac] Fullscreen Toolbar Fixes (Closed)
Patch Set: Fixed test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
index 8fae1675d0600008f10b1b748216cc6f670f8cf2..d0c0c238d3d76d934ddd22b2d7325897c8606606 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
@@ -779,14 +779,12 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
// Insert a NTP new tab in the foreground.
AddTabAtIndex(0, GURL("about:blank"), ui::PAGE_TRANSITION_LINK);
ASSERT_TRUE([[controller() toolbarController] isLocationBarFocused]);
- EXPECT_FALSE([fullscreenToolbarController isRevealingToolbarForTabstrip]);
+ EXPECT_TRUE([fullscreenToolbarController isRevealingToolbarForTabstrip]);
[fullscreenToolbarController resetToolbarFlag];
- // Insert a new tab in the background. The animation should not be triggered
- // since the location bar should still be focused.
AddTabAtBackground(1, GURL("http://google.com"));
ASSERT_TRUE([[controller() toolbarController] isLocationBarFocused]);
- EXPECT_FALSE([fullscreenToolbarController isRevealingToolbarForTabstrip]);
+ EXPECT_TRUE([fullscreenToolbarController isRevealingToolbarForTabstrip]);
[fullscreenToolbarController resetToolbarFlag];
// Switch to a non-NTP tab.
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller_private.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698