Moved window opening callback to WebStateDelegate.

Moved window opening callback to WebStateDelegate.

This partially mirrors content which also has window opening callback in
WebContentsDelegate. The difference is that in content WebContents is
created by content and in web WebState is created by chrome.

BUG=674991
Review-Url: https://codereview.chromium.org/2737943003
Cr-Commit-Position: refs/heads/master@{#455881}
Committed: https://chromium.googlesource.com/chromium/src/+/275f589e57013bde8a1626a6ef8a9c3aa181eef9

[Eugene But (OOO till 7-30), 2017-03-08 23:39:23]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2017-03-08 23:39:34]

eugenebut@chromium.org changed reviewers:
+ rohitrao@chromium.org

[commit-bot: I haz the power, 2017-03-08 23:39:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2017-03-08 23:54:31]

Will try to look at this tonight, otherwise ping me if you don't have a reply by
the time you get in tomorrow morning.

[commit-bot: I haz the power, 2017-03-08 23:57:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 23:57:24]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-03-09 00:26:14]

lgtm

https://codereview.chromium.org/2737943003/diff/20001/ios/web/public/test/fak...
File ios/web/public/test/fakes/test_web_state_delegate.h (right):

https://codereview.chromium.org/2737943003/diff/20001/ios/web/public/test/fak...
ios/web/public/test/fakes/test_web_state_delegate.h:94: // Returns list of all
child windows opened via CreateNewWebState.
Does this transfer ownership of the WebStates to the callers?

[Eugene But (OOO till 7-30), 2017-03-09 01:23:59]

Thank you for quick review!

https://codereview.chromium.org/2737943003/diff/20001/ios/web/public/test/fak...
File ios/web/public/test/fakes/test_web_state_delegate.h (right):

https://codereview.chromium.org/2737943003/diff/20001/ios/web/public/test/fak...
ios/web/public/test/fakes/test_web_state_delegate.h:94: // Returns list of all
child windows opened via CreateNewWebState.
On 2017/03/09 00:26:14, rohitrao wrote:
> Does this transfer ownership of the WebStates to the callers?
No, it returns the result by const reference to internal vector.

[Eugene But (OOO till 7-30), 2017-03-09 01:24:08]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-03-09 01:24:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 01:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 01:37:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eugene But (OOO till 7-30), 2017-03-09 22:02:47]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-03-09 22:02:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2737943003/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2017-03-09 22:04:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 22:20:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489096967272110,
"parent_rev": "8241f12c66198708d14bc08088cb00758def4762", "commit_rev":
"275f589e57013bde8a1626a6ef8a9c3aa181eef9"}

[commit-bot: I haz the power, 2017-03-09 22:21:39]

Description was changed from

==========
Moved window opening callback to WebStateDelegate.

This partially mirrors content which also has window opening callback in
WebContentsDelegate. The difference is that in content WebContents is
created by content and in web WebState is created by chrome.

BUG=674991
==========

to

==========
Moved window opening callback to WebStateDelegate.

This partially mirrors content which also has window opening callback in
WebContentsDelegate. The difference is that in content WebContents is
created by content and in web WebState is created by chrome.

BUG=674991

Review-Url: https://codereview.chromium.org/2737943003
Cr-Commit-Position: refs/heads/master@{#455881}
Committed:
https://chromium.googlesource.com/chromium/src/+/275f589e57013bde8a1626a6ef8a...
==========

[commit-bot: I haz the power, 2017-03-09 22:21:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/275f589e57013bde8a1626a6ef8a...