Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: ios/web/web_state/web_state_impl_unittest.mm

Issue 2737943003: Moved window opening callback to WebStateDelegate. (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/web_state_impl.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/web_state_impl_unittest.mm
diff --git a/ios/web/web_state/web_state_impl_unittest.mm b/ios/web/web_state/web_state_impl_unittest.mm
index b2a16a2dc16ba547009c694f2d5c4fdc693ad048..1d84b6a284e3b8cdb6f20f0db3d088c0103710d4 100644
--- a/ios/web/web_state/web_state_impl_unittest.mm
+++ b/ios/web/web_state/web_state_impl_unittest.mm
@@ -422,6 +422,37 @@ TEST_F(WebStateImplTest, DelegateTest) {
TestWebStateDelegate delegate;
web_state_->SetDelegate(&delegate);
+ // Test that CreateNewWebState() is called.
+ GURL child_url("https://child.test/");
+ GURL opener_url("https://opener.test/");
+ EXPECT_FALSE(delegate.last_create_new_web_state_request());
+ web_state_->CreateNewWebState(child_url, opener_url, true);
+ TestCreateNewWebStateRequest* create_new_web_state_request =
+ delegate.last_create_new_web_state_request();
+ ASSERT_TRUE(create_new_web_state_request);
+ EXPECT_EQ(web_state_.get(), create_new_web_state_request->web_state);
+ EXPECT_EQ(child_url, create_new_web_state_request->url);
+ EXPECT_EQ(opener_url, create_new_web_state_request->opener_url);
+ EXPECT_TRUE(create_new_web_state_request->initiated_by_user);
+
+ // Test that OpenURLFromWebState() is called.
+ WebState::OpenURLParams params(GURL("https://chromium.test/"), Referrer(),
+ WindowOpenDisposition::CURRENT_TAB,
+ ui::PAGE_TRANSITION_LINK, true);
+ EXPECT_FALSE(delegate.last_open_url_request());
+ web_state_->OpenURL(params);
+ TestOpenURLRequest* open_url_request = delegate.last_open_url_request();
+ ASSERT_TRUE(open_url_request);
+ EXPECT_EQ(web_state_.get(), open_url_request->web_state);
+ WebState::OpenURLParams actual_params = open_url_request->params;
+ EXPECT_EQ(params.url, actual_params.url);
+ EXPECT_EQ(params.referrer.url, actual_params.referrer.url);
+ EXPECT_EQ(params.referrer.policy, actual_params.referrer.policy);
+ EXPECT_EQ(params.disposition, actual_params.disposition);
+ EXPECT_TRUE(
+ PageTransitionCoreTypeIs(params.transition, actual_params.transition));
+ EXPECT_EQ(params.is_renderer_initiated, actual_params.is_renderer_initiated);
+
// Test that HandleContextMenu() is called.
EXPECT_FALSE(delegate.handle_context_menu_called());
web::ContextMenuParams context_menu_params;
« no previous file with comments | « ios/web/web_state/web_state_impl.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698