Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: ios/web/web_state/web_state_delegate_bridge.mm

Issue 2737943003: Moved window opening callback to WebStateDelegate. (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/public/web_state/web_state_delegate_bridge.h" 5 #import "ios/web/public/web_state/web_state_delegate_bridge.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #import "ios/web/public/web_state/context_menu_params.h" 8 #import "ios/web/public/web_state/context_menu_params.h"
9 9
10 namespace web { 10 namespace web {
11 11
12 WebStateDelegateBridge::WebStateDelegateBridge(id<CRWWebStateDelegate> delegate) 12 WebStateDelegateBridge::WebStateDelegateBridge(id<CRWWebStateDelegate> delegate)
13 : delegate_(delegate) {} 13 : delegate_(delegate) {}
14 14
15 WebStateDelegateBridge::~WebStateDelegateBridge() {} 15 WebStateDelegateBridge::~WebStateDelegateBridge() {}
16 16
17 WebState* WebStateDelegateBridge::CreateNewWebState(WebState* source,
18 const GURL& url,
19 const GURL& opener_url,
20 bool initiated_by_user) {
21 SEL selector =
22 @selector(webState:createNewWebStateForURL:openerURL:initiatedByUser:);
23 if ([delegate_ respondsToSelector:selector]) {
24 return [delegate_ webState:source
25 createNewWebStateForURL:url
26 openerURL:opener_url
27 initiatedByUser:initiated_by_user];
28 }
29 return nullptr;
30 }
31
17 WebState* WebStateDelegateBridge::OpenURLFromWebState( 32 WebState* WebStateDelegateBridge::OpenURLFromWebState(
18 WebState* source, 33 WebState* source,
19 const WebState::OpenURLParams& params) { 34 const WebState::OpenURLParams& params) {
20 if ([delegate_ respondsToSelector:@selector(webState:openURLWithParams:)]) 35 if ([delegate_ respondsToSelector:@selector(webState:openURLWithParams:)])
21 return [delegate_ webState:source openURLWithParams:params]; 36 return [delegate_ webState:source openURLWithParams:params];
22 return nullptr; 37 return nullptr;
23 } 38 }
24 39
25 bool WebStateDelegateBridge::HandleContextMenu( 40 bool WebStateDelegateBridge::HandleContextMenu(
26 WebState* source, 41 WebState* source,
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 completionHandler:^(NSString* username, 87 completionHandler:^(NSString* username,
73 NSString* password) { 88 NSString* password) {
74 local_callback.Run(username, password); 89 local_callback.Run(username, password);
75 }]; 90 }];
76 } else { 91 } else {
77 local_callback.Run(nil, nil); 92 local_callback.Run(nil, nil);
78 } 93 }
79 } 94 }
80 95
81 } // web 96 } // web
OLDNEW
« no previous file with comments | « ios/web/web_state/web_state_delegate.mm ('k') | ios/web/web_state/web_state_delegate_bridge_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698