Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2737863002: DevTools: move counter-related devtools.timeline trace events into probe:: probes. (Closed)

Created:
3 years, 9 months ago by pfeldman
Modified:
3 years, 9 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-html_chromium.org, pfeldman+blink_chromium.org, tyoshino+watch_chromium.org, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, blink-reviews-frames_chromium.org, kozyatinskiy+blink_chromium.org, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move counter-related devtools.timeline trace events into probe:: probes. BUG=695625 Review-Url: https://codereview.chromium.org/2737863002 Cr-Commit-Position: refs/heads/master@{#455613} Committed: https://chromium.googlesource.com/chromium/src/+/87cb93767256f83a39625de66e528ef2fb1296d5

Patch Set 1 #

Total comments: 3

Patch Set 2 : review comments addressed #

Patch Set 3 : same #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -51 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 3 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventDispatcher.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 2 chunks +44 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
pfeldman
3 years, 9 months ago (2017-03-08 00:53:06 UTC) #2
alph
https://codereview.chromium.org/2737863002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/2737863002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp#newcode612 third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:612: probe::CallFunction probe(context, function, depth); Let's have it within MicrotasksScope. ...
3 years, 9 months ago (2017-03-08 01:32:01 UTC) #3
pfeldman
all done!
3 years, 9 months ago (2017-03-08 01:33:39 UTC) #4
alph
lgtm
3 years, 9 months ago (2017-03-08 02:02:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737863002/40001
3 years, 9 months ago (2017-03-08 02:06:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/404453)
3 years, 9 months ago (2017-03-08 02:45:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737863002/40001
3 years, 9 months ago (2017-03-08 19:03:46 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/381148) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-08 19:08:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737863002/40001
3 years, 9 months ago (2017-03-08 22:14:01 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 00:36:55 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/87cb93767256f83a39625de66e52...

Powered by Google App Engine
This is Rietveld 408576698