Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

Issue 2737863002: DevTools: move counter-related devtools.timeline trace events into probe:: probes. (Closed)
Patch Set: same Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp b/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
index 20fb60af139bc2dc9b2c8630a55ba742757474cf..9c2a9302531b97feebbd15ed31c730b02dfe355d 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
@@ -616,10 +616,7 @@ void HTMLDocumentParser::pumpPendingSpeculations() {
return;
}
- // FIXME: Pass in current input length.
- TRACE_EVENT_BEGIN1("devtools.timeline", "ParseHTML", "beginData",
- InspectorParseHtmlEvent::beginData(
- document(), lineNumber().zeroBasedInt()));
+ probe::ParseHTML probe(document(), this);
SpeculationsPumpSession session(m_pumpSpeculationsSessionNestingLevel);
while (!m_speculations.isEmpty()) {
@@ -641,13 +638,6 @@ void HTMLDocumentParser::pumpPendingSpeculations() {
session, m_speculations.first()->startingScript))
break;
}
-
- TRACE_EVENT_END1(
- "devtools.timeline", "ParseHTML", "endData",
- InspectorParseHtmlEvent::endData(lineNumber().zeroBasedInt() - 1));
- TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"),
- "UpdateCounters", TRACE_EVENT_SCOPE_THREAD, "data",
- InspectorUpdateCountersEvent::data());
}
void HTMLDocumentParser::forcePlaintextForTextDocument() {

Powered by Google App Engine
This is Rietveld 408576698