DevTools: move counter-related devtools.timeline trace events into probe:: probes.

third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 591 matching lines @@
     return v8::MaybeLocal<v8::Value>();
   }
 
   // TODO(dominicc): When inspector supports tracing object
   // invocation, change this to use v8::Object instead of
   // v8::Function. All callers use functions because
   // CustomElementRegistry#define's IDL signature is Function.
   CHECK(constructor->IsFunction());
   v8::Local<v8::Function> function = constructor.As<v8::Function>();
 
-  if (!depth)
-    TRACE_EVENT_BEGIN1("devtools.timeline", "FunctionCall", "data",
-                       InspectorFunctionCallEvent::data(context, function));
+  probe::CallFunction probe(context, function, depth);

[alph, 2017/03/08 01:32:01]

Let's have it within MicrotasksScope.

   v8::MicrotasksScope microtasksScope(isolate,
                                       v8::MicrotasksScope::kRunMicrotasks);
   ThreadDebugger::willExecuteScript(isolate, function->ScriptId());
   v8::MaybeLocal<v8::Value> result =
       constructor->CallAsConstructor(isolate->GetCurrentContext(), argc, argv);
   CHECK(!isolate->IsDead());
   ThreadDebugger::didExecuteScript(isolate);
-  if (!depth)
-    TRACE_EVENT_END0("devtools.timeline", "FunctionCall");
   return result;
 }
 
 v8::MaybeLocal<v8::Value> V8ScriptRunner::callFunction(
     v8::Local<v8::Function> function,
     ExecutionContext* context,
     v8::Local<v8::Value> receiver,
     int argc,
     v8::Local<v8::Value> args[],
     v8::Isolate* isolate) {
   LocalFrame* frame =
       context->isDocument() ? toDocument(context)->frame() : nullptr;
   ScopedFrameBlamer frameBlamer(frame);
   TRACE_EVENT0("v8", "v8.callFunction");
 
   int depth = v8::MicrotasksScope::GetCurrentDepth(isolate);
   if (depth >= kMaxRecursionDepth)
     return v8::MaybeLocal<v8::Value>(
         throwStackOverflowExceptionIfNeeded(isolate));
 
   RELEASE_ASSERT(!context->isIteratingOverObservers());
 
   if (ScriptForbiddenScope::isScriptForbidden()) {
     throwScriptForbiddenException(isolate);
     return v8::MaybeLocal<v8::Value>();
   }
-  if (!depth)
-    TRACE_EVENT_BEGIN1("devtools.timeline", "FunctionCall", "data",
-                       InspectorFunctionCallEvent::data(context, function));
+  probe::CallFunction probe(context, function, depth);

[alph, 2017/03/08 01:32:01]

ditto

 
   DCHECK(!frame ||
          BindingSecurity::shouldAllowAccessToFrame(
              toDOMWindow(function->CreationContext())->toLocalDOMWindow(),
              frame, BindingSecurity::ErrorReportOption::DoNotReport));
   CHECK(!ThreadState::current()->isWrapperTracingForbidden());
   v8::MicrotasksScope microtasksScope(isolate,
                                       v8::MicrotasksScope::kRunMicrotasks);
-  probe::CallFunction probe(context, function);
   ThreadDebugger::willExecuteScript(isolate, function->ScriptId());
   v8::MaybeLocal<v8::Value> result =
       function->Call(isolate->GetCurrentContext(), receiver, argc, args);
   CHECK(!isolate->IsDead());
   ThreadDebugger::didExecuteScript(isolate);
-  if (!depth)
-    TRACE_EVENT_END0("devtools.timeline", "FunctionCall");
+
   return result;
 }
 
 v8::MaybeLocal<v8::Value> V8ScriptRunner::callInternalFunction(
     v8::Local<v8::Function> function,
     v8::Local<v8::Value> receiver,
     int argc,
     v8::Local<v8::Value> args[],
     v8::Isolate* isolate) {
   TRACE_EVENT0("v8", "v8.callFunction");
@@ skipping 54 matching lines @@
           v8AtomicString(isolate, "((e) => { throw e; })"), origin)
           .ToLocalChecked();
   v8::Local<v8::Function> thrower = runCompiledInternalScript(isolate, script)
                                         .ToLocalChecked()
                                         .As<v8::Function>();
   v8::Local<v8::Value> args[] = {exception};
   callInternalFunction(thrower, thrower, WTF_ARRAY_LENGTH(args), args, isolate);
 }
 
 }  // namespace blink