Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 2737403003: Use IdTargetObserver in SVGSMILElement (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use IdTargetObserver in SVGSMILElement Move SVGSMILElement (target reference) and SVGSMILElement::Condition to use IdTargetObserver via SVGURIReference::observeTarget. Simplify the result to avoid needing the lookupEventBase helper. BUG=661598 Review-Url: https://codereview.chromium.org/2737403003 Cr-Commit-Position: refs/heads/master@{#456367} Committed: https://chromium.googlesource.com/chromium/src/+/ef3b9727c297214c9a7093cdf51f92200d78140c

Patch Set 1 #

Patch Set 2 : Disconnect event-bases in buildPendingResource #

Patch Set 3 : Rebase; always attempt to unobserve #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -43 lines) Patch
M third_party/WebKit/Source/core/svg/SVGURIReference.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGURIReference.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h View 4 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 1 2 9 chunks +24 lines, -40 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
fs
3 years, 9 months ago (2017-03-13 12:19:21 UTC) #14
Stephen Chennney
lgtm
3 years, 9 months ago (2017-03-13 13:51:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737403003/40001
3 years, 9 months ago (2017-03-13 13:52:09 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 13:57:44 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ef3b9727c297214c9a7093cdf51f...

Powered by Google App Engine
This is Rietveld 408576698