Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h

Issue 2737403003: Use IdTargetObserver in SVGSMILElement (Closed)
Patch Set: Rebase; always attempt to unobserve Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h
diff --git a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h
index 5973ced40fae88088127f93a27a3ce500614c32d..214eecc8c205535cec21fb655d965154bf30ee71 100644
--- a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h
+++ b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h
@@ -38,6 +38,7 @@ namespace blink {
class ConditionEventListener;
class SMILTimeContainer;
+class IdTargetObserver;
class SVGSMILElement;
// This class implements SMIL interval timing model as needed for SVG animation.
@@ -216,8 +217,6 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests {
SMILTime offset,
int repeat);
- SVGElement* lookupEventBase(SVGSMILElement&) const;
-
Type m_type;
BeginOrEnd m_beginOrEnd;
AtomicString m_baseID;
@@ -225,6 +224,7 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests {
SMILTime m_offset;
int m_repeat;
Member<SVGElement> m_baseElement;
+ Member<IdTargetObserver> m_baseIdObserver;
Member<ConditionEventListener> m_eventListener;
};
bool parseCondition(const String&, BeginOrEnd beginOrEnd);
@@ -246,6 +246,7 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests {
SMILTime calculateNextProgressTime(double elapsed) const;
Member<SVGElement> m_targetElement;
+ Member<IdTargetObserver> m_targetIdObserver;
HeapVector<Member<Condition>> m_conditions;
bool m_syncBaseConditionsConnected;

Powered by Google App Engine
This is Rietveld 408576698