Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/core/svg/SVGURIReference.cpp

Issue 2737403003: Use IdTargetObserver in SVGSMILElement (Closed)
Patch Set: Rebase; always attempt to unobserve Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGURIReference.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGURIReference.cpp b/third_party/WebKit/Source/core/svg/SVGURIReference.cpp
index 3606053b47217abd58d79ab7933ae173741197a5..2e300619cc80847c2f03a801f3e8060a0ce0a0f5 100644
--- a/third_party/WebKit/Source/core/svg/SVGURIReference.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGURIReference.cpp
@@ -118,8 +118,14 @@ Element* SVGURIReference::targetElementFromIRIString(
Element* SVGURIReference::observeTarget(Member<IdTargetObserver>& observer,
SVGElement& contextElement) {
+ return observeTarget(observer, contextElement, hrefString());
+}
+
+Element* SVGURIReference::observeTarget(Member<IdTargetObserver>& observer,
+ SVGElement& contextElement,
+ const String& hrefString) {
TreeScope& treeScope = contextElement.treeScope();
- AtomicString id = fragmentIdentifierFromIRIString(hrefString(), treeScope);
+ AtomicString id = fragmentIdentifierFromIRIString(hrefString, treeScope);
return observeTarget(observer, treeScope, id,
WTF::bind(&SVGElement::buildPendingResource,
wrapWeakPersistent(&contextElement)));
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGURIReference.h ('k') | third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698