Converts WmActivationObserver to aura::client::ActivationChangeObserver

Converts WmActivationObserver to aura::client::ActivationChangeObserver

I had to make Shell add WmShell as the ActivationChangeObserver
because of ordering issues. This is ugly, but my next patch will move
this to Shell, so it's temporary.

BUG=699231
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2736753005
Cr-Commit-Position: refs/heads/master@{#455386}
Committed: https://chromium.googlesource.com/chromium/src/+/589a5bec0318f116d4f269facc6d9b6b79fda9c1

[sky, 2017-03-08 00:25:05]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 00:25:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 01:47:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:47:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2017-03-08 02:54:12]

LGTM. Hopefully the browser test failures aren't anything serious.

https://codereview.chromium.org/2736753005/diff/20001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2736753005/diff/20001/ash/shell.cc#newcode684
ash/shell.cc:684: activation_client_->AddObserver(wm_shell_.get());
nit: I would also add a note that this is cleaned up in WmShell (since it's odd
that the cleanup isn't in this file).

[sky, 2017-03-08 05:04:06]

https://codereview.chromium.org/2736753005/diff/20001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2736753005/diff/20001/ash/shell.cc#newcode684
ash/shell.cc:684: activation_client_->AddObserver(wm_shell_.get());
On 2017/03/08 02:54:12, James Cook wrote:
> nit: I would also add a note that this is cleaned up in WmShell (since it's
odd
> that the cleanup isn't in this file).

I'm going to leave this as the next patch nukes it.

[sky, 2017-03-08 05:13:46]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-08 05:14:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 05:53:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488950026718820,
"parent_rev": "d265114438e787fbcefdbe0e081491349a5816b4", "commit_rev":
"589a5bec0318f116d4f269facc6d9b6b79fda9c1"}

[commit-bot: I haz the power, 2017-03-08 05:54:22]

Description was changed from

==========
Converts WmActivationObserver to aura::client::ActivationChangeObserver

I had to make Shell add WmShell as the ActivationChangeObserver
because of ordering issues. This is ugly, but my next patch will move
this to Shell, so it's temporary.

BUG=699231
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Converts WmActivationObserver to aura::client::ActivationChangeObserver

I had to make Shell add WmShell as the ActivationChangeObserver
because of ordering issues. This is ugly, but my next patch will move
this to Shell, so it's temporary.

BUG=699231
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2736753005
Cr-Commit-Position: refs/heads/master@{#455386}
Committed:
https://chromium.googlesource.com/chromium/src/+/589a5bec0318f116d4f269facc6d...
==========

[commit-bot: I haz the power, 2017-03-08 05:54:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/589a5bec0318f116d4f269facc6d...