Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: ash/shell.cc

Issue 2736753005: Converts WmActivationObserver to aura::client::ActivationChangeObserver (Closed)
Patch Set: cleanup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index 90c62c0b85af397d0abb5a33da500ac9527fdbff..6e03f8ecc972d36648cb701c5cd542155a18d90c 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -680,6 +680,8 @@ void Shell::Init(const ShellInitParams& init_params) {
new ::wm::FocusController(focus_rules);
focus_client_.reset(focus_controller);
activation_client_ = focus_controller;
+ // TODO(sky): Shell should implement ActivationChangeObserver, not WmShell.
+ activation_client_->AddObserver(wm_shell_.get());
James Cook 2017/03/08 02:54:12 nit: I would also add a note that this is cleaned
sky 2017/03/08 05:04:06 I'm going to leave this as the next patch nukes it
screen_position_controller_.reset(new ScreenPositionController);

Powered by Google App Engine
This is Rietveld 408576698