Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2026)

Unified Diff: ash/common/wm/workspace/workspace_layout_manager.h

Issue 2736753005: Converts WmActivationObserver to aura::client::ActivationChangeObserver (Closed)
Patch Set: cleanup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/wm/workspace/workspace_layout_manager.h
diff --git a/ash/common/wm/workspace/workspace_layout_manager.h b/ash/common/wm/workspace/workspace_layout_manager.h
index 85413a71ae21927a415f794ade9b94645e45492a..af7d795d69e05e309242b47f13fc3a9e0d0d3a36 100644
--- a/ash/common/wm/workspace/workspace_layout_manager.h
+++ b/ash/common/wm/workspace/workspace_layout_manager.h
@@ -12,13 +12,13 @@
#include "ash/common/shell_observer.h"
#include "ash/common/wm/window_state_observer.h"
#include "ash/common/wm/wm_types.h"
-#include "ash/common/wm_activation_observer.h"
#include "ash/common/wm_layout_manager.h"
#include "base/macros.h"
#include "ui/aura/window_observer.h"
#include "ui/display/display_observer.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/keyboard/keyboard_controller_observer.h"
+#include "ui/wm/public/activation_change_observer.h"
namespace ash {
@@ -35,7 +35,7 @@ class WMEvent;
class ASH_EXPORT WorkspaceLayoutManager
: public WmLayoutManager,
public aura::WindowObserver,
- public WmActivationObserver,
+ public aura::client::ActivationChangeObserver,
public keyboard::KeyboardControllerObserver,
public display::DisplayObserver,
public ShellObserver,
@@ -71,9 +71,10 @@ class ASH_EXPORT WorkspaceLayoutManager
const gfx::Rect& old_bounds,
const gfx::Rect& new_bounds) override;
- // WmActivationObserver overrides:
- void OnWindowActivated(WmWindow* gained_active,
- WmWindow* lost_active) override;
+ // aura::client::ActivationChangeObserver overrides:
+ void OnWindowActivated(ActivationReason reason,
+ aura::Window* gained_active,
+ aura::Window* lost_active) override;
// keyboard::KeyboardControllerObserver overrides:
void OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) override;

Powered by Google App Engine
This is Rietveld 408576698