Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2736093003: [fasta] Add and correct offsets on nodes (Closed)

Created:
3 years, 9 months ago by jensj
Modified:
3 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -43 lines) Patch
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 8 chunks +12 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart View 3 chunks +6 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 2 chunks +20 lines, -12 lines 1 comment Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 6 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
With these changes 6 more service tests pass (at least when hacking to include source).
3 years, 9 months ago (2017-03-08 12:25:12 UTC) #2
ahe
lgtm https://codereview.chromium.org/2736093003/diff/1/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart File pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart (right): https://codereview.chromium.org/2736093003/diff/1/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart#newcode127 pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart:127: _makeRead() => new VariableGet(variable, promotedType)..fileOffset = charOffset; Long ...
3 years, 9 months ago (2017-03-08 12:31:49 UTC) #3
jensj
3 years, 9 months ago (2017-03-09 09:32:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e553775b9c8edf090f1ecba3cd96285c3c05ceff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698